Joseph Eagar JosephEagar
9 Followers · 0 Following
  • Sacramento, California, USA
  • Joined on 2004-09-20
Repositories
1
 Projects Public Activity Starred Repositories
Joseph Eagar commented on pull request blender/blender#104668 2023-04-22 02:32:50 +02:00
Add ASAN support to BLI_mempool

I thought ASAN didn't work at all for VS2019? Or has MS been backporting bugfixes?

Joseph Eagar pushed to mempool_asan at JosephEagar/blender 2023-04-22 02:29:24 +02:00
f60f77fab2 mempool_asan: Do not poison pool
4a5660648d Merge branch 'main' into mempool_asan
21b51e7b88 Cleanup: Use function ref instead of pointer for transform gizmo
c547ff1ebd Fix VSE thumbnails are displayed from incorrect scene
968ecf6f8b Fix #106993: Slowness with Orbiting around select + Mesh Symmetry
Compare 217 commits »
Joseph Eagar commented on pull request blender/blender#104668 2023-04-22 01:44:45 +02:00
Add ASAN support to BLI_mempool

I'm on Windows and I did test it, yes.

Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-22 01:39:26 +02:00
cfc638d4b2 temp-sculpt-dyntopo: Fix trim booleans
a04c6e15a8 temp-sculpt-dyntopo: Fix crash in box trim
Compare 2 commits »
Joseph Eagar commented on pull request blender/blender#104668 2023-04-20 22:21:21 +02:00
Add ASAN support to BLI_mempool

MSVC added support for ASAN a year or two ago. Clang's windows support for ASAN is actually pretty unstable, so MSVC is the…

Joseph Eagar commented on pull request blender/blender#104668 2023-04-20 22:14:41 +02:00
Add ASAN support to BLI_mempool

I ran into a few cases where the system allocator put the mempool struct close enough to one of its chunks to get corrupted by out of bounds errors.

Joseph Eagar commented on pull request blender/blender#104668 2023-04-20 22:07:35 +02:00
Add ASAN support to BLI_mempool

Sorry about that, I missed those.

Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-20 01:14:23 +02:00
d439ae22af Merge branch 'main' into temp-sculpt-dyntopo
911f9bea84 Fix #107067: Properly clear CD_FLAG_ACTIVE/DEFAULT_COLOR flags
e05cbad0d1 Sculpt: Fix #107093: expand helper function not specialized to pbvh
2ab500c234 Cleanup: Remove unnecessary point cloud function argument
7535ab412a Cleanup: Remove redundant "reference" argument to geometry copy
Compare 48 commits »
Joseph Eagar pushed to main at blender/blender 2023-04-19 21:59:23 +02:00
e05cbad0d1 Sculpt: Fix #107093: expand helper function not specialized to pbvh
Joseph Eagar closed issue blender/blender#107093 2023-04-19 21:59:23 +02:00
Multires: Expand Face Set operators don't work on some objects
Joseph Eagar pushed to main at blender/blender 2023-04-19 21:41:42 +02:00
c6d4de9e49 Render: Fix crash in baking
Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-19 08:56:16 +02:00
4dbd79499a temp-sculpt-dyntopo: fix compile error
Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-19 08:54:21 +02:00
75eab27366 temp-sculpt-dyntopo: Fix compile error
Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-19 08:49:17 +02:00
6682751b28 Merge branch 'main' into temp-sculpt-dyntopo
6d2351d26b Text object: operators to move cursor to the top or bottom
846d78b09a Cleanup: improve doc-strings for EditFont
b132118f89 Cleanup: balance doxygen grouping, minor grouping adjustment
88f5dd3c72 Cleanup: format
Compare 103 commits »
Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-19 03:30:06 +02:00
6d53e23e03 temp-sculpt-dyntopo: bugfixes
Joseph Eagar commented on pull request blender/blender#104668 2023-04-19 00:37:56 +02:00
Add ASAN support to BLI_mempool

What I'm saying is that there shouldn't be a need to change the behavior of code (adding synchronization) to avoid false-positives (where ASAN would detect an error but things are actually…

Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-04-18 01:47:02 +02:00
59801f80c1 temp-sculpt-dyntopo: Fix bug with valence caching in PBVH_GRIDS
52dd137e53 temp-sculpt-dyntopo: Fix bug in CustomData_copy_all_layout
Compare 2 commits »
Joseph Eagar pushed to main at blender/blender 2023-04-18 00:16:55 +02:00
29f137e138 Sculpt: fix brush.falloff_shape not being reset in "reset brush" op
Joseph Eagar commented on issue blender/blender#101144 2023-04-18 00:06:17 +02:00
paint.sample_color operator options no longer accessible by default due to undo flag removal

If supporting undo for color changes is sufficiently important we can handle it inside the sculpt undo stack, though that's a bit hackish. It would be better to fix memfile undo so if you push a…

Joseph Eagar commented on pull request blender/blender#104668 2023-04-18 00:02:13 +02:00
Add ASAN support to BLI_mempool

As for the mutex, it's there because the iterator code unpoisons and poisons memory.

Sounds to me as if the code is either poisoning memory that it shouldn't poison or it is accessing…