paint.sample_color operator options no longer accessible by default due to undo flag removal #101144
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#101144
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59
Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash:
e05e1e3691Worked: 3.1.2
Short description of error
The undo flag for
paint.sample_colorwas removed in https://developer.blender.org/rB511a08585d2934b38e7d3de447752686b5f0e15b, this means that the 'redo toolbar panel' no longer pops up after sampling color with the default keybinding of 'S'. Previously, users could change the default settings through the 'redo toolbar panel', without it, I don't think the "Sample Merged" and "Add to Palette" options are accessible to users by default any more.I'm not sure if this should be considered a bug or an API change, but for the latter, I think there should at least be some other way to access these options through the UI or default keybindings without requiring users to create new keybindings with these options specifically enabled/disabled.
'redo toolbar panel':
Exact steps for others to reproduce the error
S(default keybinding ofpaint.sample_color)Added subscriber: @Mysteryem-2
Added subscriber: @PratikPB2123
Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'
Added subscribers: @JosephEagar, @JulienKaspar
Thanks for the report. I'm not sure whether this change was discussed before committing. So forwarding this report to developers.
@JosephEagar Can you look into this. Seems not all sampling operators were taken into account when that change was made.
Added subscriber: @Astrexis
Added subscriber: @lichtwerk
Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'
I recall issues regarding the Palette option (see #78181 (Texture Paint: Color Palette operator issues with Undo/Redo -- Vertex Paint is fine though)), but
Sample Mergedis quite important?Think I also proposed another fix in #78181 (to just hide the palette stuff from the UI).
Will confirm for now until we have more insights from @JosephEagar
Any updates/info on this @JosephEagar ?
From the commit message:
Well, at least you need to be able to redo this (to change the options)
Mind elaborating?
If supporting undo for color changes is sufficiently important we can handle it inside the sculpt undo stack, though that's a bit hackish. It would be better to fix memfile undo so if you push a memfile step after a sculpt one it doesn't ignore it.
Is there a recommended workaround for easy access to sample merged until/unless this is resolved? Is the best approach to just create a custom key binding to do sample vs sample merged?
@andrewoates A custom shortcut would be the ideal workaround for now, yes.