Is there a reason we do sampling here like this instead of the usual
Please provide a PR description. Is this work part of a bigger effort? Is there a design task?
This came up as part of my work to optimize the current node socket animdata versioning, but I…
I'd specifically avoid "Conductor" since it's not using the actual conductor Fresnel term, unlike the other two.
"F82-Tint" is the name I've seen others use for this model, so yeah, I guess…
Ah, yes, that looks good. I'm not too familiar with the "core" Blender C++ style yet.
LGTM now, I merged main and updated the versioning number.
Looks reasonable to me, assuming the build passes.
@blender-bot build +gpu
Also, thinking about it some more, I'm not that happy with "F82 Approximation" as a UI name anymore, it seems too technical. I can't really come up with anything better though, so I'm open to suggestions.
Maybe "An approximation of the Conductor Fresnel curve based on the perpendicular color and the tint at an angle of 82°, also used by the Principled BSDF" as a description?