Lukas Stockner LukasStockner
17 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
5
 Projects Public Activity Starred Repositories
Lukas Stockner pushed to white-balance at LukasStockner/blender 2024-06-27 23:22:08 +02:00
c9b405587d Increase step for temperature UI slider
28094cdb7b Don't completely disable Curves and White Balance panels
7e7f2dea5f Add Eyedropper operator to panel header
4563c6b2c1 Support prop_data_path in color eyedropper
4cbfea7886 Expand comments
Compare 510 commits »
Lukas Stockner commented on pull request blender/blender#123278 2024-06-27 22:50:15 +02:00
Color management: Support white balance as part of the display transform

Wow, that is quite a list of presets. But guess people would love to have them all.

To be honest, I had no idea which ones are relevant in practice so I just took all of them.

Lukas Stockner suggested changes for blender/blender#123737 2024-06-27 22:44:53 +02:00
Fix and test direction_to_fisheye_lens_polynomial

Overall seems good (especially having tests!), just three nitpicks.

Lukas Stockner commented on pull request blender/blender#123737 2024-06-27 22:44:52 +02:00
Fix and test direction_to_fisheye_lens_polynomial

Can't we avoid the trigonometric functions here by

Lukas Stockner commented on pull request blender/blender#123737 2024-06-27 22:44:51 +02:00
Fix and test direction_to_fisheye_lens_polynomial

Nitpick: I'd prefer explicitly computing F_r and dF_r and then updating r based on that. It's fairly obvious here what the respective terms are, but that spells it out more clearly.

Lukas Stockner commented on pull request blender/blender#123737 2024-06-27 22:44:49 +02:00
Fix and test direction_to_fisheye_lens_polynomial

Nitpick: I'd prefer sqr(r) and putting these both in the same line, they're short enough and related.

Lukas Stockner approved blender/blender#123613 2024-06-27 21:24:34 +02:00
Fix: Add missing thin film parameters to MaterialX export
Lukas Stockner commented on pull request blender/blender#114958 2024-06-24 23:33:53 +02:00
Shader: Add Metallic BSDF Node

Agreed, this is definitely good to have (also for physically-based metallic thin film in the future). Sorry for letting this one slip through the cracks, I'll do a proper review soon.

Lukas Stockner pushed to main at LukasStockner/.profile 2024-06-24 12:48:58 +02:00
cd94c40d5f Update reports/2024.md
Lukas Stockner pushed to principled-diffuse-roughness at LukasStockner/blender 2024-06-24 00:41:59 +02:00
d0d7d941ea Cycles: Add Diffuse Roughness option to Principled BSDF
b59fbbe865 Cleanup: Formatting
26eb5d9899 EEVEE: Adapt Principled BSDF to closure sampling
3b9081d093 Merge branch 'blender-v4.2-release'
b1287ad6d4 Cleanup: remove unused extensions.repo_add_from_drop operator
Compare 25 commits »
Lukas Stockner pushed to main at blender/blender 2024-06-24 00:40:00 +02:00
b59fbbe865 Cleanup: Formatting
Lukas Stockner deleted branch principled-eevee-next from LukasStockner/blender 2024-06-24 00:20:54 +02:00
Lukas Stockner pushed to main at blender/blender 2024-06-24 00:20:51 +02:00
26eb5d9899 EEVEE: Adapt Principled BSDF to closure sampling
Lukas Stockner merged pull request blender/blender#123643 2024-06-24 00:20:51 +02:00
EEVEE: Adapt Principled BSDF to closure sampling
Lukas Stockner commented on pull request blender/blender#123616 2024-06-24 00:01:03 +02:00
Cycles: Add Diffuse Roughness option to Principled BSDF

Okay, I think I got, !123643 should address the issue. I'll just wait for that to be done.

Lukas Stockner created pull request blender/blender#123643 2024-06-23 23:59:45 +02:00
EEVEE: Adapt Principled BSDF to closure sampling
Lukas Stockner pushed to principled-eevee-next at LukasStockner/blender 2024-06-23 23:57:55 +02:00
c10e563f30 EEVEE: Adapt Principled BSDF to closure sampling
4547260bda Merge branch 'blender-v4.2-release'
4bde68cdd6 Cycles: Compress GPU kernels to reduce file size
Compare 3 commits »
Lukas Stockner created branch principled-eevee-next in LukasStockner/blender 2024-06-23 23:57:55 +02:00
Lukas Stockner commented on pull request blender/blender#123616 2024-06-23 20:08:28 +02:00
Cycles: Add Diffuse Roughness option to Principled BSDF

Yes, but the clamping should happen in bsdf_oren_nayar_setup so that it only affects the multiscattering color correction.

Lukas Stockner commented on pull request blender/blender#123616 2024-06-23 20:07:35 +02:00
Cycles: Add Diffuse Roughness option to Principled BSDF

We can remove the do_diffuse optimization flags. They are not necessary since EEVEE-Next.

Same for the other do_* flags? If yes, that should be enough for a while.

Eventually we might…