Lukas Stockner LukasStockner
16 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
4
 Projects Public Activity Starred Repositories
Lukas Stockner approved blender/blender#114958 2024-08-07 03:55:42 +02:00
Shader: Add Metallic BSDF Node
Lukas Stockner commented on pull request blender/blender#125919 2024-08-07 03:54:07 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

@blender-bot build

Lukas Stockner approved blender/blender#125919 2024-08-07 02:43:50 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff
Lukas Stockner pushed to fix-pointdensity-osl at LukasStockner/blender 2024-08-07 02:37:52 +02:00
3597dade81 Fix #124646: Cycles: Point Density node still works on surfaces in OSL
b119e1a497 Cycles: Fix potential NaN in normal mapping
c20bb31325 Refactor: Encapsulate SculptSession#active_vertex
9ed7d38aac Cycles: Improve numerical precision of Beckmann distribution at low roughness
aca466b029 Cleanup: Sculpt: Remove now unused brush strength function
Compare 77 commits »
Lukas Stockner suggested changes for blender/blender#114958 2024-08-07 02:31:20 +02:00
Shader: Add Metallic BSDF Node

Pretty much LGTM now, just two small notes.

Lukas Stockner commented on pull request blender/blender#114958 2024-08-07 02:31:19 +02:00
Shader: Add Metallic BSDF Node

This needs to be 0.99f, otherwise the compiler complains. Same in the function below.

Lukas Stockner commented on pull request blender/blender#114958 2024-08-07 02:31:18 +02:00
Shader: Add Metallic BSDF Node

Should probably be 0.8f, 0.8f, 0.8f, 1.0f for consistency.

Lukas Stockner pushed to animdata-versioning-cleanup at LukasStockner/blender 2024-08-07 02:17:01 +02:00
f2e8a96253 Refactor animdata iterators to C++ callbacks
Lukas Stockner created pull request blender/blender#125999 2024-08-07 02:13:20 +02:00
Cycles: Cleanup: Consolidate/speedup coordinate system conversions
Lukas Stockner deleted branch fix-normal-nan from LukasStockner/blender 2024-08-07 02:07:40 +02:00
Lukas Stockner pushed to main at blender/blender 2024-08-07 02:07:39 +02:00
b119e1a497 Cycles: Fix potential NaN in normal mapping
Lukas Stockner merged pull request blender/blender#125930 2024-08-07 02:07:38 +02:00
Cycles: Fix potential NaN in normal mapping
Lukas Stockner created branch cleanup-trig in LukasStockner/blender 2024-08-07 02:06:11 +02:00
Lukas Stockner pushed to cleanup-trig at LukasStockner/blender 2024-08-07 02:06:11 +02:00
e5d290a59e Use helpers to transform from/to local coordinate systems
cc67ced5b0 Replace various sin/cos computations with sincosf
ea83c3f43c Deduplicate Fisheye projection code
d300a9b024 Replace spherical conversions with shared helpers
e0f8c21077 Add helper functions
Compare 10 commits »
Lukas Stockner pushed to main at blender/blender 2024-08-06 23:04:41 +02:00
9ed7d38aac Cycles: Improve numerical precision of Beckmann distribution at low roughness
Lukas Stockner commented on pull request blender/blender#125919 2024-08-06 21:03:27 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

That being said, a much more robust formulation of D_beckmann would be expf((cos_NH2 - 1.0f) / (cos_NH2 * alpha2)) / (M_PI_F * alpha2 * sqr(cos_NH2)).

For reference - for `cos_NH2 == 1.0 -…

Lukas Stockner commented on pull request blender/blender#125919 2024-08-06 20:52:02 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

I don't think it makes sense to seriously try to support Beckmann at alpha2 == 2e-10f. Even at cos_NH2 == 1.0f - epsilon, the largest possible value below 1, D_Beckmann gives ~2e-208 according…

Lukas Stockner commented on pull request blender/blender#125933 2024-08-06 20:32:18 +02:00
WIP: Cycles: Add Render Time pass

I think we can have a post-processing step to normalize the value to [0, 1]. The absolute time shouldn't matter because we have that in the status anyway.

Good idea, that also removes the…

Lukas Stockner created pull request blender/blender#125933 2024-08-06 00:53:25 +02:00
WIP: Cycles: Add Render Time pass
Lukas Stockner pushed to render-time-pass at LukasStockner/blender 2024-08-06 00:53:01 +02:00
4a57fd6b21 Render Time pass
bd6d255f3a Add fast timer
Compare 2 commits »