Lukas Stockner LukasStockner
  • Joined on 2013-12-26
Lukas Stockner created branch white-balance in LukasStockner/blender 2024-06-16 03:36:11 +02:00
Lukas Stockner commented on pull request blender/blender#123267 2024-06-15 22:14:24 +02:00
Fix #123249: Orthographic DOF is influenced by near clip

I feel like we should just remove the translation in projection_orthographic instead of explicitly undoing it here.

Lukas Stockner pushed to main at blender/blender 2024-06-15 22:07:02 +02:00
d0f0e38bf2 Merge branch 'blender-v4.2-release'
e118fe6e47 Cycles: Fix directional artifacts in blue noise sampling pattern
Compare 2 commits »
Lukas Stockner deleted branch blue-seed from LukasStockner/blender 2024-06-15 22:05:32 +02:00
Lukas Stockner pushed to blender-v4.2-release at blender/blender 2024-06-15 22:05:30 +02:00
e118fe6e47 Cycles: Fix directional artifacts in blue noise sampling pattern
Lukas Stockner merged pull request blender/blender#123274 2024-06-15 22:05:30 +02:00
Cycles: Fix directional artifacts in blue noise sampling pattern
Lukas Stockner commented on pull request blender/blender#123274 2024-06-15 21:59:49 +02:00
Cycles: Fix directional artifacts in blue noise sampling pattern

The rather boring outcome of an interesting investigation 😄

Before realizing the problem, I tested a number of other approaches:

  • "Tweak": The tweak mentioned in footnote 5 of @nathanvegd…
Lukas Stockner created pull request blender/blender#123274 2024-06-15 21:49:36 +02:00
Cycles: Fix directional artifacts in blue noise sampling pattern
Lukas Stockner pushed to blue-seed at LukasStockner/blender 2024-06-15 21:47:43 +02:00
2708092af6 Cycles: Fix directional artifacts in blue noise sampling pattern
b11d8d2e74 Fix #121559: bad node tree zone visibility with frames
a6628fc299 Fix #123255: flickering background in node tree zones
50c5771a77 Build: rebuild OSL (update LFS), resolve LLVM linking error
2cccc941a8 Build: rebuild OSL (update LFS)
Compare 10 commits »
Lukas Stockner created branch blue-seed in LukasStockner/blender 2024-06-15 21:47:43 +02:00
Lukas Stockner commented on issue blender/blender#122990 2024-06-13 00:36:41 +02:00
Color management: Easy way to define white point

To provide more context here following the meeting discussion:

This operation would sit in the display transformation pipeline, at the same stage where the curve mapping currently is.

There's…

Lukas Stockner suggested changes for blender/blender#123046 2024-06-13 00:22:44 +02:00
Cycles: add Central Cylindrical Panoramic camera model

Code seems mostly fine, just a few nitpicks. I've also left comments in the existing threads.

Lukas Stockner commented on pull request blender/blender#123046 2024-06-13 00:22:43 +02:00
Cycles: add Central Cylindrical Panoramic camera model

Not sure if we have guidelines for comment style, but I think C-style /* */ comments are preferred?

Lukas Stockner commented on pull request blender/blender#123046 2024-06-13 00:22:42 +02:00
Cycles: add Central Cylindrical Panoramic camera model

Nitpick: mix(range.x, range.y, u) and mix(range.z, range.w, v).

Lukas Stockner commented on pull request blender/blender#123046 2024-06-13 00:22:41 +02:00
Cycles: add Central Cylindrical Panoramic camera model

Nitpick: inverse_lerp(atan2f(dir.y, dir.x), range.x, range.y) and inverse_lerp(dir.z, range.z, range.w)

Lukas Stockner commented on pull request blender/blender#123046 2024-06-13 00:17:08 +02:00
Cycles: add Central Cylindrical Panoramic camera model

I don't think we need a subversion bump here, you can just use DNA_struct_member_exists since the fields are new.

Lukas Stockner commented on pull request blender/blender#123046 2024-06-13 00:16:14 +02:00
Cycles: add Central Cylindrical Panoramic camera model

We could make it clearer (through the comment) that this really is a factor relative to the cylinder radius, whatever it is. For an end user, it should be straightforward to compute `physical…

Lukas Stockner commented on pull request blender/blender#122935 2024-06-12 01:45:16 +02:00
Cycles: Implement better ellipse sampling for area lights

Update: Here's a version with the CDF lookup table approach, as described in the paper. The LUT is generated by the attached script: [precompute_sample_table.py](/attachments/ede23608-058c-44f4-b87…

Lukas Stockner pushed to ellipse-sampling at LukasStockner/blender 2024-06-12 01:33:50 +02:00
efa897d048 Use lookup table to invert area CDF
954d84ebad Use lookup table and numerical fit for ellipse solid angle
Compare 2 commits »
Lukas Stockner commented on pull request blender/blender#122935 2024-06-11 17:40:06 +02:00
Cycles: Implement better ellipse sampling for area lights

After some tweaking, I got the approximation error down to 0.004% on average and 0.08% maximum (out of 10000 random inputs) using a 32x32 table.

This also behaves well in the limits from what I…