Lukas Stockner LukasStockner
  • Joined on 2013-12-26
Lukas Stockner deleted branch iridescence from LukasStockner/blender 2024-05-02 14:29:00 +02:00
Lukas Stockner merged pull request blender/blender#118477 2024-05-02 14:28:58 +02:00
Cycles: Add thin film iridescence to Principled BSDF
Lukas Stockner pushed to main at blender/blender 2024-05-02 14:28:57 +02:00
17f2cdd104 Cycles: Add thin film iridescence to Principled BSDF
Lukas Stockner commented on pull request blender/blender#118477 2024-05-02 02:46:34 +02:00
Cycles: Add thin film iridescence to Principled BSDF
  • Updated default IOR to 1.33
  • Fixed issue with near-parallel incidence
  • Using wavelength units
  • Rebased to latest main
Lukas Stockner pushed to iridescence at LukasStockner/blender 2024-05-02 02:45:11 +02:00
d149ae8550 Fix thin film effect with bulk IOR 1.0
92ef41d2a0 Use Wavelength subtype, default to IOR 1.33
47217648a8 Fix F0 scaling
f164d469e3 Address review comments
118cad45c3 Fix albedo computation
Compare 391 commits »
Lukas Stockner commented on issue blender/blender#120901 2024-04-29 03:51:55 +02:00
Blend files with a lot of Shape Keys aren't compressed efficiently

Okay, some more info: I've got an implementation of this working, and it indeed delivers the expected 25MB file size.

However, all implementations that I've thought of so far are a regression…

Lukas Stockner created pull request blender/blender#121197 2024-04-29 03:08:16 +02:00
Build: Don't use bundled zstd for blosc
Lukas Stockner pushed to fix-zstd-conflict at LukasStockner/blender 2024-04-29 03:07:01 +02:00
fd105260da Build: Don't use bundled zstd for blosc
29c7be1516 Tools: fixes and updates to duplicate header checker
4ec93f73a5 Cleanup: spelling in comments
c9dba4d31f Cleanup: use const variables & argument, remove duplicate include
4156a925ef Cleanup: avoid str.format when adding the strings is sufficient
Compare 267 commits »
Lukas Stockner pushed to fix-zstd-conflict at LukasStockner/blender 2024-04-29 03:04:57 +02:00
d783d3c9cf Build: Don't use bundled zstd for blosc
583c0c1981 Temp
Compare 2 commits »
Lukas Stockner created branch fix-zstd-conflict in LukasStockner/blender 2024-04-29 03:04:56 +02:00
Lukas Stockner commented on issue blender/blender#120901 2024-04-23 03:49:28 +02:00
Blend files with a lot of Shape Keys aren't compressed efficiently

I believe I found what's going on here.

In the compression code, there's a tradeoff on chunk size: On the one hand, you want chunks to be as large as possible so the compressor can find…

Lukas Stockner commented on pull request blender/blender#118477 2024-04-23 01:25:26 +02:00
Cycles: Add thin film iridescence to Principled BSDF

@blender-bot build +gpu

Lukas Stockner pushed to iridescence at LukasStockner/blender 2024-04-23 01:24:45 +02:00
4453b67e5c Address review comments
Lukas Stockner deleted branch iridescence from blender/blender 2024-04-23 01:24:36 +02:00
Lukas Stockner pushed to iridescence at blender/blender 2024-04-23 01:23:33 +02:00
4453b67e5c Address review comments
5921fdfc56 Fix albedo computation
d28ec7509e Combine dielectric Fresnel functions
87cf785752 Fix backfacing think film IOR computation
9ae5c0d3e6 Fix TIR on the bottom thin-film interface
Compare 10 commits »
Lukas Stockner created branch iridescence in blender/blender 2024-04-23 01:23:31 +02:00
Lukas Stockner commented on pull request blender/blender#118477 2024-04-23 01:23:04 +02:00
Cycles: Add thin film iridescence to Principled BSDF

Ah, okay, I wasn't sure if that's supported on GPU but looks like it is.

Lukas Stockner suggested changes for blender/blender#119042 2024-04-23 01:10:32 +02:00
Cycles Refactor: Replace fixed Tangent input with custom input

Wrong button, sorry.

Lukas Stockner approved blender/blender#119042 2024-04-23 01:10:20 +02:00
Cycles Refactor: Replace fixed Tangent input with custom input

I think this change is small enough to go through for now, but in general I agree with @Sergey that the parameter handling in its current form is a mess:

Lukas Stockner commented on pull request blender/blender#119042 2024-04-23 01:10:18 +02:00
Cycles Refactor: Replace fixed Tangent input with custom input

I'd prefer to add a SVMCompiler::is_linked to check these conditions, seems a bit cleaner than repeating them here.