Lukas Stockner LukasStockner
17 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
5
 Projects Public Activity Starred Repositories
Lukas Stockner closed issue blender/blender#117657 2024-02-04 00:36:22 +01:00
Generalized Schlick transmits too much light in certain situations.
Lukas Stockner pushed to main at blender/blender 2024-01-30 10:31:44 +01:00
58b9240c82 Cycles: Separate the caustics controls for Generalized Schlick
Lukas Stockner merged pull request blender/blender#117617 2024-01-30 10:31:44 +01:00
Cycles: Separate the caustics controls for Generalized Schlick
Lukas Stockner approved blender/blender#117617 2024-01-30 10:31:08 +01:00
Cycles: Separate the caustics controls for Generalized Schlick
Lukas Stockner commented on pull request blender/blender#117617 2024-01-29 22:53:09 +01:00
Cycles: Separate the caustics controls for Generalized Schlick

Overall LGTM, just one detail: I think with this, if (reflect_caustics_disabled && refract_caustics_disabled && has_reflect && has_transmit) in osl_closure_skip can be replaced with just if (reflect_caustics_disabled && refract_caustics_disabled)? After all, if both types are skipped, we will not have any contribution regardless of the tint values.

Lukas Stockner pushed to main at LukasStockner/.profile 2024-01-29 01:13:03 +01:00
77dba32e1b 2024 CW 4
Lukas Stockner deleted branch ies-type-a from LukasStockner/blender 2024-01-29 01:04:04 +01:00
Lukas Stockner pushed to main at blender/blender 2024-01-29 01:04:03 +01:00
82811cf489 Cycles: Support Type-A IES files
Lukas Stockner merged pull request blender/blender#114689 2024-01-29 01:04:02 +01:00
Cycles: Support Type-A IES files
Lukas Stockner commented on pull request blender/blender#114354 2024-01-29 00:49:22 +01:00
Shader: Add specular tint to Glass BSDF

Hm, this is a tricky one.

Lukas Stockner merged pull request blender/blender#115081 2024-01-29 00:37:22 +01:00
Cycles: Improve handling of Principled BSDF Caustics settings
Lukas Stockner pushed to main at blender/blender 2024-01-29 00:37:22 +01:00
e6a3d46fe5 Cycles: Improve handling of Principled BSDF Caustics settings
Lukas Stockner merged pull request blender/blender#114518 2024-01-29 00:36:39 +01:00
Versioning: Better conversion of Specular tint for metals
Lukas Stockner pushed to main at blender/blender 2024-01-29 00:36:39 +01:00
020f6ec0ff Versioning: Better conversion of Specular tint for metals
Lukas Stockner approved blender/blender#115081 2024-01-28 19:53:29 +01:00
Cycles: Improve handling of Principled BSDF Caustics settings

LGTM, definitely an improvement over the previous logic.

Lukas Stockner commented on pull request blender/blender#115081 2024-01-28 19:53:28 +01:00
Cycles: Improve handling of Principled BSDF Caustics settings

Nitpick: This might be a bit nicer if we also add const bool has_reflect = (scattering & LABEL_REFLECT) and similar for transmit above.

Lukas Stockner commented on pull request blender/blender#114518 2024-01-28 19:36:56 +01:00
Versioning: Better conversion of Specular tint for metals

@blender-bot build

Lukas Stockner pushed to no-spec-tint-on-metal at Alaska/blender 2024-01-28 19:36:25 +01:00
cc5906eff1 Rebase versioning code on the work done by Lukas Stockner
93b28b54fc Cleanup: Geometry Nodes: Use int instead of uint16_t
25f32a2191 Cleanup: Geometry Nodes: Unused function
f795d81a88 Cleanup: Use const for enum item variables and arguments
a3d915310b Build: Fix some excessive Visual Studio compile times
Compare 1791 commits »
Lukas Stockner pushed to main at blender/blender 2024-01-23 01:22:12 +01:00
b5a9c98e04 Fix #117081: Wrong Roughness when baking Principled BSDF
Lukas Stockner closed issue blender/blender#117081 2024-01-23 01:22:11 +01:00
Baking roughness affected by base color (Principled BSDF)