Lukas Stockner LukasStockner
  • Joined on 2013-12-26
Lukas Stockner commented on pull request blender/blender#114518 2023-11-23 22:32:07 +01:00
Versioning: Better conversion of Specular tint for metals

I think something went wrong with the PR, it shows 4167 files changed...

Lukas Stockner commented on issue blender/blender#114956 2023-11-18 19:48:50 +01:00
blender 4.0 : Transmission Roughness is missing in Principled BSDF, preventing some textures from being used correctly in previous versions

Yeah, the socket was removed intentionally.

The reason is that many assumptions of the new Fresnel handling, new multiscattering approximation etc. rely on specular and transmission using the…

Lukas Stockner commented on pull request blender/blender#114960 2023-11-18 19:44:43 +01:00
Cycles: Fix invalid normals in various situations

For zero normal inputs, the most straightforward fix would be to just return N as-is and skip the process. The entire algorithm is undefined for that case.

I'd go a step further and argue…

Lukas Stockner commented on pull request blender/blender#114958 2023-11-18 19:38:12 +01:00
Shader: Add Metallic BSDF Node

Generally this is good to have, but I think we should a) support the full range of Microfacet distributions and b) have an enum for switching between F82 Fresnel and the proper conductive Fresnel…

Lukas Stockner commented on pull request blender/blender#114689 2023-11-10 03:40:20 +01:00
Cycles: Support Type-A IES files

@blender-bot package

Lukas Stockner created pull request blender/blender#114689 2023-11-10 03:40:06 +01:00
WIP: Cycles: Support Type-A IES files
Lukas Stockner pushed to ies-type-a at LukasStockner/blender 2023-11-10 03:39:28 +01:00
361bd099b9 Cycles: Support Type-A IES files
Lukas Stockner created branch ies-type-a in LukasStockner/blender 2023-11-10 03:39:28 +01:00
Lukas Stockner pushed to main at LukasStockner/blender 2023-11-10 03:39:25 +01:00
78943edc5d Transform: Custom modifier to navigate while transforming
8eb5223663 Cleanup: remove unused variables & imports in scripts/
a615dcdfa8 Cleanup: add missing header to CMake, sort file lists
3841addab3 Cleanup: spelling in comments
4e6bca79cd Cleanup: quiet unused variable warnings in CMake
Compare 2082 commits »
Lukas Stockner commented on pull request blender/blender#114518 2023-11-07 03:31:01 +01:00
Versioning: Better conversion of Specular tint for metals

I've found one case where I don't think the behavior is expected: When using a variable Metallic input (e.g. a texture) with a fixed Specular Tint (e.g. 0.5), the code produces two Mix nodes, and…

Lukas Stockner pushed to no-spec-tint-on-metal at LukasStockner/blender 2023-11-07 03:27:20 +01:00
e5dfc075a2 Cycles: Adjust Principled BSDF versioning of Specular Tint
abe925d0c6 Fix #114436: Crash when right clicking certain, nested, popup dialogs
fe9e28c086 Fix build error on macOS x86, after Metal motion blur workaround
10848b9774 Fix #114229: Hydra MaterialX crash when node name starts with digit
4f52ab0b49 Cycles: Workaround MetalRT TLAS build hanging in some motion blur scenes
Compare 10 commits »
Lukas Stockner created branch no-spec-tint-on-metal in LukasStockner/blender 2023-11-07 03:27:20 +01:00
Lukas Stockner approved blender/blender#114500 2023-11-06 00:51:51 +01:00
Fix #114435: Harsh Principled BSDF Subsurface transition in EEVEE

Seems reasonable - EEVEE isn't doing the diffuse/SSS closure mix that Cycles now does, so the old behavior is probably as good as it gets for now.

Lukas Stockner closed issue blender/blender#113898 2023-11-01 19:30:13 +01:00
Regression: New Principled BSDF does not load keyframes or drivers correctly from prior versions
Lukas Stockner commented on issue blender/blender#113898 2023-11-01 19:30:07 +01:00
Regression: New Principled BSDF does not load keyframes or drivers correctly from prior versions

Fixed with #114300 / 0b81a163e2560a3f72a512ad00d101af54081868.

Not updating automatically generated conversion setups is accepted as a known limitation for now.

Lukas Stockner deleted branch fix-principled-animdata from LukasStockner/blender 2023-11-01 19:28:02 +01:00
Lukas Stockner merged pull request blender/blender#114300 2023-11-01 19:28:00 +01:00
Cycles: Fix Principled BSDF versioning for keyframes and drivers
Lukas Stockner pushed to blender-v4.0-release at blender/blender 2023-11-01 19:28:00 +01:00
0b81a163e2 Cycles: Fix Principled BSDF versioning for keyframes and drivers