Lukas Stockner LukasStockner
16 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
4
 Projects Public Activity Starred Repositories
Lukas Stockner pushed to animdata-versioning-cleanup at LukasStockner/blender 2024-08-04 19:57:05 +02:00
ef9a29481a Refactor animdata iterators to C++ callbacks
a57c3be05e UI: Add SVG Icons for Status Bar Event Use
dd905de795 Fix #125838: Elastic deform brush does not respect mask values
be4c7cae7c Cleanup: format
afa44b16a6 Fix error installing app-templates & legacy add-ons overwriting symlinks
Compare 262 commits »
Lukas Stockner commented on pull request blender/blender#125676 2024-08-02 19:06:12 +02:00
Fix #125595: Cycles artifacts in overlapping volumes with different phase functions

Is there a reason we do sampling here like this instead of the usual

Lukas Stockner commented on pull request blender/blender#125485 2024-07-30 11:35:34 +02:00
Cleanup: Refactor animdata iterators to C++ callbacks

Please provide a PR description. Is this work part of a bigger effort? Is there a design task?

This came up as part of my work to optimize the current node socket animdata versioning, but I…

Lukas Stockner pushed to main at LukasStockner/.profile 2024-07-29 17:30:28 +02:00
9271a777d1 Update reports/2024.md
Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 17:28:45 +02:00
Shader: Add Metallic BSDF Node

I'd specifically avoid "Conductor" since it's not using the actual conductor Fresnel term, unlike the other two.

"F82-Tint" is the name I've seen others use for this model, so yeah, I guess…

Lukas Stockner commented on pull request blender/blender#125485 2024-07-29 17:26:53 +02:00
Cleanup: Refactor animdata iterators to C++ callbacks

Ah, yes, that looks good. I'm not too familiar with the "core" Blender C++ style yet.

Lukas Stockner pushed to main at blender/blender-developer-docs 2024-07-29 15:06:21 +02:00
7de241e59c Update docs/release_notes/4.3/cycles.md
Lukas Stockner merged pull request blender/blender#123046 2024-07-29 15:04:16 +02:00
Cycles: add Central Cylindrical Panoramic camera model
Lukas Stockner pushed to main at blender/blender 2024-07-29 15:04:14 +02:00
5e9096829c Cycles: Add Central Cylindrical Panoramic camera model
Lukas Stockner approved blender/blender#123046 2024-07-29 14:33:11 +02:00
Cycles: add Central Cylindrical Panoramic camera model

LGTM now, I merged main and updated the versioning number.

Lukas Stockner pushed to cylindrical_projection at softyoda/blender 2024-07-29 14:32:21 +02:00
1371d8a058 Merge remote-tracking branch 'origin/main' into cylindrical_projection
e0cdfb8566 Fix: Docstring of the bpy.utils.user_resource argument
101d54fb7f Cleanup: Readfile: Remove unused function.
9a3e102853 Fix: Workbench: Disable overlays_enabled optimizations
0bd1b92133 Fix: APIENTRY redefinition warning
Compare 991 commits »
Lukas Stockner commented on pull request blender/blender#125323 2024-07-29 14:16:14 +02:00
Cleanup: Avoid includes where possible and move around some code in Cycles headers for that purpose

Looks reasonable to me, assuming the build passes.

Lukas Stockner commented on pull request blender/blender#125323 2024-07-29 14:15:23 +02:00
Cleanup: Avoid includes where possible and move around some code in Cycles headers for that purpose

@blender-bot build +gpu

Lukas Stockner suggested changes for blender/blender#114958 2024-07-29 14:10:34 +02:00
Shader: Add Metallic BSDF Node
Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 14:10:33 +02:00
Shader: Add Metallic BSDF Node

Also, thinking about it some more, I'm not that happy with "F82 Approximation" as a UI name anymore, it seems too technical. I can't really come up with anything better though, so I'm open to suggestions.

Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 14:10:32 +02:00
Shader: Add Metallic BSDF Node

Maybe "An approximation of the Conductor Fresnel curve based on the perpendicular color and the tint at an angle of 82°, also used by the Principled BSDF" as a description?

Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 14:10:31 +02:00
Shader: Add Metallic BSDF Node

Looks like e.g. node_shader_clamp.cc is using it.

Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 14:10:30 +02:00
Shader: Add Metallic BSDF Node

Based on node_parser.h, I think node_ should work?

Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 14:08:38 +02:00
Shader: Add Metallic BSDF Node

Hm, let's keep it for now, it's not too much complexity.

Lukas Stockner commented on pull request blender/blender#114958 2024-07-29 14:07:44 +02:00
Shader: Add Metallic BSDF Node

Maybe "Physically accurate Fresnel effect based on the complex IOR of the material" as the description?