Lukas Stockner LukasStockner
17 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
5
 Projects Public Activity Starred Repositories
Lukas Stockner pushed to fix-principled-animdata at LukasStockner/blender 2023-11-01 19:05:41 +01:00
48c66be4ed Cycles: Fix Principled BSDF versioning for keyframes and drivers
39f7411065 Fix "make bpy" on macOS not install libraries inside bpy module
01b617a3c6 VSE: remove speed_factor RNA property from sound strips
d503f2ac33 Fix #114177: Crash in extrude mesh vertex mode with unsupported data
66c1ca7419 Fix #114102: Node tool data-block inputs broken
Compare 6 commits »
Lukas Stockner commented on pull request blender/blender#114300 2023-11-01 18:56:35 +01:00
Cycles: Fix Principled BSDF versioning for keyframes and drivers

Yes, seems like it does. However, as far as I can tell, BKE_animdata_fix_paths_rename_all_ex does the same - the nodetree ID that is being passed into it is only used in one bone-specific check…

Lukas Stockner commented on pull request blender/blender#114300 2023-11-01 05:30:20 +01:00
Cycles: Fix Principled BSDF versioning for keyframes and drivers

The crash was solved by moving the logic to do_versions_after_linking_400.

Also, I've added code to remove animdata for the removed sockets, it turned out to be easier than expected.

Lukas Stockner pushed to fix-principled-animdata at LukasStockner/blender 2023-11-01 05:29:24 +01:00
4f54ad4f5e Remove obsolete animdata for removed sockets
6a05e023d6 Cycles: Fix Principled BSDF versioning for keyframes and drivers
960e2c73de Docs: improve bpy.app.driver_namespace, add stub example
f6c52849b5 Fix #112729: Update pinned blender shortcut
977c62c708 Docs: remove dpi from blf.size doc as it's deprecated
Compare 32 commits »
Lukas Stockner pushed to main at blender/blender 2023-10-31 06:17:57 +01:00
d15013b583 Merge branch 'blender-v4.0-release'
4bec9d0d71 Fix #114282: Extrude to Cursor tool no longer tweaks on drag
a15f9e49ec Shader: Only clamp undefined or unsupported inputs of Principled BSDF
Compare 3 commits »
Lukas Stockner created pull request blender/blender#114300 2023-10-31 05:44:24 +01:00
WIP: Cycles: Fix Principled BSDF versioning for keyframes and drivers
Lukas Stockner pushed to fix-principled-animdata at LukasStockner/blender 2023-10-31 05:38:43 +01:00
97dc0de163 Cycles: Fix Principled BSDF versioning for keyframes and drivers
a15f9e49ec Shader: Only clamp undefined or unsupported inputs of Principled BSDF
b27ff093ca Build: resolve error configuring FFMPEG on Linux
39107b3133 Revert changes from main commits that were merged into blender-v4.0-release
b26f176d1a Fix #114096: Workbench: Broken thumbnail shadows
Compare 10 commits »
Lukas Stockner created branch fix-principled-animdata in LukasStockner/blender 2023-10-31 05:38:43 +01:00
Lukas Stockner pushed to blender-v4.0-release at blender/blender 2023-10-31 03:14:15 +01:00
a15f9e49ec Shader: Only clamp undefined or unsupported inputs of Principled BSDF
Lukas Stockner merged pull request blender/blender#112895 2023-10-31 03:14:15 +01:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF
Lukas Stockner approved blender/blender#112895 2023-10-24 03:05:50 +02:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF

Considering that the 4.0 release is coming closer, I'd say we stick with this for now.

Lukas Stockner commented on pull request blender/blender#112895 2023-10-23 02:09:17 +02:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF

Should we mix between the clamped and unclamped base color based on the metallic and subsufrace weight inputs? See previous comment.

Honestly, I'd skip it. Setting Base Color over one is…

Lukas Stockner pushed to blender-v4.0-release at blender/blender 2023-10-20 00:34:33 +02:00
686aece797 Shader: Adjust Coat Tint Color intensity based on Coat Weight
Lukas Stockner merged pull request blender/blender#113468 2023-10-20 00:34:33 +02:00
Shader: Adjust Coat Tint Color intensity based on Coat Weight
Lukas Stockner pushed to main at blender/blender 2023-10-19 13:29:56 +02:00
173ba71b6b Merge branch 'blender-v4.0-release'
c71e18054c Fix: Cycles: Non-physical layering weights can lead to negative closures
Compare 2 commits »
Lukas Stockner pushed to blender-v4.0-release at blender/blender 2023-10-19 13:18:31 +02:00
c71e18054c Fix: Cycles: Non-physical layering weights can lead to negative closures
Lukas Stockner commented on pull request blender/blender#112895 2023-10-19 03:43:06 +02:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF

General comment: I'd prefer to keep clamping explicit in the shader code, even if the closure's internals do it already. That way, we don't e.g. accidentally break compatibility if we change the closure's internals, and it's easier to ensure that things stay consistent. The performance impact should be negligible.

Lukas Stockner commented on pull request blender/blender#112895 2023-10-19 03:43:06 +02:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF

Shouldn't this be [0..inf]?

Lukas Stockner commented on pull request blender/blender#112895 2023-10-19 03:43:05 +02:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF

As above - having all the clamping together at the start makes it more maintainable (except for cases where the same parameter gets clamped differently depending on context).

Lukas Stockner commented on pull request blender/blender#112895 2023-10-19 03:43:05 +02:00
Shader: Only clamp undefined or unsupported inputs of Principled BSDF

Shouldn't this stay [0..1]?