Lukas Stockner

Lukas Stockner deleted branch fix-111588 from LukasStockner/blender

2023-10-02 02:20:05 +02:00

Lukas Stockner closed issue blender/blender#111588

2023-10-02 02:20:02 +02:00

Vector displacement on top of adaptive subdivision breaks normal

Lukas Stockner pushed to blender-v4.0-release at blender/blender

2023-10-02 02:20:00 +02:00

b1a91c99bc Fix #111588: Cycles: Vector displacement with adaptive subdiv breaks normal

Lukas Stockner merged pull request blender/blender#112987

2023-10-02 02:19:59 +02:00

Fix #111588: Cycles: Vector displacement with adaptive subdiv breaks normal

Lukas Stockner pushed to fix-111588 at LukasStockner/blender

2023-10-02 02:14:49 +02:00

68a86edba5 Fix #111588: Cycles: Vector displacement with adaptive subdiv breaks normal

4d35344010 UI: UI: Anchor Right When Double-Clicking Last Word

fef8b38acb UI: Less Cursor Changes While Loading Files

c2ff509159 Fix incorrect function name in foreach_get/foreach_set exceptions

18f8579e38 Follow up to fix for #111117, remove array/collection length lookup

Compare 63 commits »

Lukas Stockner commented on pull request blender/blender#113071

2023-10-02 01:57:33 +02:00

blenloader: Refactor the write wrappers.

Seems overall reasonable to me, virtual functions are definitely nicer.

Lukas Stockner commented on pull request blender/blender#113071

2023-10-02 01:57:33 +02:00

blenloader: Refactor the write wrappers.

I'd make this a non-static function and add a (static) write_task wrapper in ZstdWriteBlockTask that essentially just casts userdata to a ZstdWriteBlockTask and calls task->ww->write_task(task).

Lukas Stockner commented on pull request blender/blender#113071

2023-10-02 01:57:32 +02:00

blenloader: Refactor the write wrappers.

Not sure what the code style policy is here, but I'm personally not a big fan of a static overload of a function that's part of the public interface. I'd prefer something like an _impl suffix here.

Lukas Stockner created pull request blender/blender#112987

2023-09-28 02:53:15 +02:00

Fix #111588: Cycles: Vector displacement with adaptive subdiv breaks normal

Lukas Stockner pushed to fix-111588 at LukasStockner/blender

2023-09-28 02:52:02 +02:00

b93e8603d1 Fix #111588: Cycles: Vector displacement with adaptive subdiv breaks normal

751c9ef620 CMake/MSVC: Fix build error for RelWithDebInfo configuration

13f5879e3c UI: Splash Screen Changes

1badb464b0 Fix: Compile error from unused module requested in CMake

e0fe8d4698 Fix AppIcon on macOS

Compare 10 commits »

Lukas Stockner created branch fix-111588 in LukasStockner/blender

2023-09-28 02:52:01 +02:00

Lukas Stockner commented on issue blender/blender#111588

2023-09-28 00:16:33 +02:00

Vector displacement on top of adaptive subdivision breaks normal

This is caused by the compact differential representation that was added a while ago to help with GPU memory usage.

With OSL, the full dPdx/dPdy differentials are tracked in ShaderGlobals, so…

Lukas Stockner pushed to main at blender/blender

2023-09-27 03:03:22 +02:00

2456897d9d Fix #112831: Cycles: Kernel assert and NaN in Sheen

Lukas Stockner closed issue blender/blender#112831

2023-09-27 03:03:21 +02:00

Cycles: Kernel assert and NaN in Sheen

Lukas Stockner approved blender/blender#112895

2023-09-26 13:50:26 +02:00

Shader: Only clamp undefined or unsupported inputs of Principled BSDF

Clamping Base Color makes sense, for Emission I wouldn't do it - Emission naturally supports any positive value, while reflectivity (in a physically based renderer) is inherently limited to 0..1.

Lukas Stockner approved blender/blender#112894

2023-09-26 13:45:42 +02:00

Cycles: Fix missing specular tint for SVM transmissive Principled BSDF

Lukas Stockner commented on pull request blender/blender#112848

2023-09-25 16:39:45 +02:00

Principled v2 combined changes for 4.0

Sorry, the line number got messed up here. I meant subsurface_weight.

Lukas Stockner commented on pull request blender/blender#112848

2023-09-25 16:39:33 +02:00

Principled v2 combined changes for 4.0

Sorry, the line number got messed up here. I meant the specular_tint.

Lukas Stockner commented on pull request blender/blender#112848