Lukas Stockner LukasStockner
17 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
5
 Projects Public Activity Starred Repositories
Lukas Stockner commented on pull request blender/blender#112848 2023-09-25 16:38:38 +02:00
Principled v2 combined changes for 4.0

Same as in EEVEE, I don't think we want to hard-clamp >1.0 anymore.

Lukas Stockner commented on pull request blender/blender#112848 2023-09-25 16:38:37 +02:00
Principled v2 combined changes for 4.0

I think this is still left over from before the "Tint is now a color" change? I don't think we want a hard limit on 1.0 now.

Lukas Stockner commented on pull request blender/blender#112848 2023-09-25 16:38:37 +02:00
Principled v2 combined changes for 4.0

This should also be clamped between 0.0 and 1.0, a mix factor >1 makes no sense.

Lukas Stockner commented on pull request blender/blender#112551 2023-09-25 03:43:13 +02:00
Cycles: Add Metallic Tint to Principled BSDF using F82-Tint model

Alright, I rebased this on top of #112192 to reuse the Specular Tint parameter.

I guess we should merge that first and then rebase this branch again.

Lukas Stockner pushed to principled-metallic at LukasStockner/blender 2023-09-25 03:41:39 +02:00
14eae8df60 Cycles: Add Metallic Tint to Principled BSDF using F82-Tint model
9f714a61c3 Merge remote-tracking branch 'origin/main' into principled-specular-tint
26e56d0b52 Fix: Correct UI string in previous fix
15f24bd248 Fix #112814: New geometry nodes always named "Tool"
25b9e8b13b UI: Inter Font with regular (non-slashed) zero
Compare 216 commits »
Lukas Stockner commented on pull request blender/blender#112192 2023-09-25 02:25:06 +02:00
Cycles/EEVEE: Change specular tint in Principled BSDF from float to color

Is it still planned to be merged for 4.0?

Currently yes afaik.

Lukas Stockner approved blender/blender#112192 2023-09-25 02:24:48 +02:00
Cycles/EEVEE: Change specular tint in Principled BSDF from float to color
Lukas Stockner pushed to principled-specular-tint at weizhen/blender 2023-09-25 02:24:10 +02:00
9f714a61c3 Merge remote-tracking branch 'origin/main' into principled-specular-tint
26e56d0b52 Fix: Correct UI string in previous fix
15f24bd248 Fix #112814: New geometry nodes always named "Tool"
25b9e8b13b UI: Inter Font with regular (non-slashed) zero
eef2a706b4 Fix: UI: garbage string when invoking search from menu
Compare 156 commits »
Lukas Stockner commented on pull request blender/blender#112192 2023-09-25 02:16:13 +02:00
Cycles/EEVEE: Change specular tint in Principled BSDF from float to color

For glass this actually tints the transmission color too because we use one_spectrum() - F. Is this intended? Should we use reduce_max as we do for layering?

Yeah, this is a tricky question.…

Lukas Stockner pushed to principled-specular-ior-adjust at LukasStockner/blender 2023-09-25 01:58:25 +02:00
7bfad432bf Cycles: Change Specular input on Principled BSDF to affect IOR
26e56d0b52 Fix: Correct UI string in previous fix
15f24bd248 Fix #112814: New geometry nodes always named "Tool"
25b9e8b13b UI: Inter Font with regular (non-slashed) zero
eef2a706b4 Fix: UI: garbage string when invoking search from menu
Compare 191 commits »
Lukas Stockner commented on pull request blender/blender#112552 2023-09-25 01:44:07 +02:00
Cycles/EEVEE: Change Specular input on Principled BSDF to affect IOR

Good point about the transmission. OpenPBR does combine them (see the section about dispersion), but for now I think we can keep them separate.

As for naming - maybe "Specular Adjust"?

Lukas Stockner commented on pull request blender/blender#112552 2023-09-25 01:43:00 +02:00
Cycles/EEVEE: Change Specular input on Principled BSDF to affect IOR

Ah, yeah, I wasn't sure what the ideal place for it is here.

With the updated version, this is irrelevant anyways since we don't need ior_from_f0 anymore.

Also, I agree that we should…

Lukas Stockner commented on pull request blender/blender#112552 2023-09-25 01:41:40 +02:00
Cycles/EEVEE: Change Specular input on Principled BSDF to affect IOR

True, but I'm not really sure how to phrase it better without making the description overly verbose.

Lukas Stockner created pull request blender/blender#112552 2023-09-19 05:03:46 +02:00
Cycles: Change Specular input on Principled BSDF to affect IOR
Lukas Stockner created branch principled-specular-ior-adjust in LukasStockner/blender 2023-09-19 04:59:03 +02:00
Lukas Stockner pushed to principled-specular-ior-adjust at LukasStockner/blender 2023-09-19 04:59:03 +02:00
ccb1c973ed Cycles: Change Specular input on Principled BSDF to affect IOR
Lukas Stockner pushed to principled-metallic at LukasStockner/blender 2023-09-19 04:58:59 +02:00
ff1d0695b9 Formatting
Lukas Stockner created pull request blender/blender#112551 2023-09-19 03:20:31 +02:00
Cycles: Add Metallic Tint to Principled BSDF using F82-Tint model
Lukas Stockner pushed to principled-metallic at LukasStockner/blender 2023-09-19 03:18:37 +02:00
f2d28362c3 Cycles: Add Metallic Tint to Principled BSDF using F82-Tint model
Lukas Stockner created branch principled-metallic in LukasStockner/blender 2023-09-19 03:18:37 +02:00