The fix for links not showing up is merged now - I think we can just merge this as-is and handle the short-name topic (and panels in the property editor) as a follow-up?
LGTM - looks like tests need to be updated, but it's only a few fireflies that are different.
Ah okay, maybe Blender and Cycles drifted apart a bit here? Anyways, you're right that this is not really consistent, so I think we can just leave this.
Ah yeah, good point. All of these only get called from one location anyways, so it's much nicer to do a clean initialization there than to do it 100x in each individual BSDF.
I like the idea of ordering it based on layering, just feels intuitive to me. But I don't really have a strong opinion.
I think Roughness and IOR should be in the Specular panel, with that panel first and expanded by default.
Metallic and Transmission probably as well. When there are more transmission…
Hello @LukasStockner
(Also tagging @ThomasDinges as coordinator)
Seems the current status is behind the initial planning for 4.0 I'd like to have a updated status of each item:…
Looks great! The new approach is much cleaner.
This might cause issues if r_cos_theta_r is NULL, just use cosT I guess.
Nitpick: The if above explicitly checks for non-positive cosT_sq, so this can be a regular sqrt.
Nitpick: I think we generally use 2 as a suffix to indicate squared values, like cosT2?