Lukas Stockner LukasStockner
17 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
5
 Projects Public Activity Starred Repositories
Lukas Stockner pushed to emission-principled at LukasStockner/blender 2023-08-16 01:53:53 +02:00
c54e867262 Versioning for rare corner case
fd4ad794e2 Cycles: Also move transparency into Principled node internally
8bc33c2e62 Cycles: Move Emission in Principled BSDF below Sheen and Coat
Compare 3 commits »
Lukas Stockner commented on pull request blender/blender#105600 2023-08-16 00:52:51 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

@LukasStockner There is a problem with your change. Because num_closure is set to 2 in shader_graph.cpp, when it tries to allocate a transparent closure in bsdf_microfacet_hair_setup() it would…

Lukas Stockner commented on pull request blender/blender#110993 2023-08-15 15:17:00 +02:00
Cycles: Rework Principled BSDF Clearcoat
  • Fixed the blue=0 issue
  • Adjusted versioning - now the IOR 1.2 trick is only used when the Coat input was dynamic (in this case, we avoid needing a Math node). If the input has a fixed value,…
Lukas Stockner pushed to clearcoat-principled at LukasStockner/blender 2023-08-15 15:15:38 +02:00
b204134463 Tweak versioning, only use 1.2 IOR for dynamic Coat input
c5219c9cd5 Fix albedo divide for zero-weight components
Compare 2 commits »
Lukas Stockner commented on pull request blender/blender#110989 2023-08-15 14:38:05 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

For naming, now about "Random Walk (non-organic)" and "Random Walk (organic)"? The same arguments about complex interface layers also apply to e.g. plants, but not to e.g. marble, so that might be…

Lukas Stockner commented on pull request blender/blender#110993 2023-08-15 14:01:22 +02:00
Cycles: Rework Principled BSDF Clearcoat

Thanks for the review!

Blender crashes when using EEVEE with this pull request on the Metal backend for Blender (Tested with a M1 Pro). I haven't done much debugging on the Metal EEVEE side…

Lukas Stockner pushed to clearcoat-principled at LukasStockner/blender 2023-08-15 13:58:08 +02:00
c8a53394c7 Adress review comments
Lukas Stockner commented on pull request blender/blender#110993 2023-08-15 13:57:52 +02:00
Cycles: Rework Principled BSDF Clearcoat

Thanks, should be fixed now I think?

Lukas Stockner commented on pull request blender/blender#110989 2023-08-15 03:40:25 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

Okay, updated version here:

  • Fixed sampling bug in GGX entry bounce
  • Removed shadowing-masking term from GGX entry to avoid darkening (we only care about the direction distribution here, so…
Lukas Stockner commented on pull request blender/blender#110993 2023-08-15 02:57:17 +02:00
Cycles: Rework Principled BSDF Clearcoat
  • Rebased
  • Added Coat IOR as discussed above
  • Added descriptions to Coat node sockets
  • Tint now reacts to the Coat input

One remaining detail: When creating a new file, it appears that…

Lukas Stockner pushed to clearcoat-principled at LukasStockner/blender 2023-08-15 02:54:09 +02:00
2771d57ae2 Format
9398da4a41 Add Socket descriptions
ee0aa52f27 Add Coat IOR
d1d654c2b3 Fix Metal compilation
0ce2870752 Fix Eevee
Compare 120 commits »
Lukas Stockner pushed to subsurface-principled at LukasStockner/blender 2023-08-15 02:04:07 +02:00
419c648634 Bring back Subsurface IOR, remove Subsurface Color
e22e651312 Avoid GGX darkening
2e19855b48 Update logic for falling back to diffuse
993df6a8db Cycles: Implement refractive BSSRDF entry bounce
2a58b41c69 Cycles: Tweak Principled BSDF Subsurface parameters
Compare 152 commits »
Lukas Stockner commented on pull request blender/blender#110989 2023-08-11 10:07:19 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

Now for the roughness. Remember, this boundary is not directly in relationship with the specular component. We want a compound effect through multiple layers of dead cells (stratum corneum),…

Lukas Stockner pushed to clearcoat-principled at LukasStockner/blender 2023-08-11 06:46:36 +02:00
ca6de1282d Fix Metal compilation
e2be6d5be0 Fix Eevee
c7b16389a8 Format
82e9e8ff14 Add versioning for Principled BSDF coat
5e256b7133 Remove hardcoded 0.25 clearcoat weight multiplier
Compare 155 commits »
Lukas Stockner commented on pull request blender/blender#110993 2023-08-11 00:29:17 +02:00
Cycles: Rework Principled BSDF Clearcoat

This is probably unintentional so that's why I'm reporting it.

Changing the Coat Tint colour while the coat parameter is set to 0 still has an impact on the material. ![Clear coat…

Lukas Stockner deleted branch layering-principled from LukasStockner/blender 2023-08-10 23:53:46 +02:00
Lukas Stockner pushed to main at blender/blender 2023-08-10 23:53:46 +02:00
2ac0b36e4e Cycles: Rework component layering in Principled BSDF
Lukas Stockner merged pull request blender/blender#110864 2023-08-10 23:53:45 +02:00
Cycles: Rework component layering in Principled BSDF
Lukas Stockner pushed to layering-principled at LukasStockner/blender 2023-08-10 23:51:00 +02:00
6a3c2f62c5 Formatting
606e594527 Address review comments
76a56b11b8 Remove now-unused special OSL closure
c986f4e01f Improve albedo estimation for rough microfacet closures with Fresnel
9183d4fa31 Swap order of sheen and clearcoat
Compare 156 commits »
Lukas Stockner commented on pull request blender/blender#110989 2023-08-10 20:00:54 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

@Christophe-Hery, you may have feedback on this.

We've briefly talked at SIGGRAPH. This PR is only about parametrization, I've got a second branch (no PR yet) for updating how the entry…