Looks like Metal doesn't have cbrtf, but that's not an issue. We can just add our own fast inverse cube root function and use that instead. The one I added has average relative error of ~1e-7…
Pushed the cleaned-up version. Since I split up the commits for easier reviewing and rebased the whole thing, it's a force push - sorry for that, you'll need to manually update your local…
Instead of posting even more review comments, I'll just pull this, make my suggested cleanups and update the PR. I hope that's fine for everyone :)
I followed @weizhen's suggestion and renamed these to to_global/to_local, added templates and a comment explaining what they do.
Is the speedup supposed to come from the
sinf/cosf->sincosf? Did you measure any speedup? In my experience I never saw such changes gaining any speedup: either platform simply doesn't…
Before, the sign conversion for the spherical conversion was different in some places (such as the Sky texture). To unify it, I had to change the offset for sun_rotation here, which means that…
MEM_freeN doesn't appear to like const char * arguments...
Since the topic came up, I've created a pull request for OpenImageIO to be able to process (read/write) our existing JPEG metadata scheme: https://github.com/AcademySoftwareFoundation/OpenImageIO/p…
Relevant documentation: https://openexr.com/en/latest/MultiViewOpenEXR.html Note that using multi-part to store both multiple views and multiple passes (in their example, rgb/diff/spec) is…
@LukasStockner Hey, any chance to take a look at this one? :)
Sure - I looked into this a while ago, I remember that it wasn't a trivial fix but we should definitely be able to do better…