Lukas Stockner LukasStockner
16 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
4
 Projects Public Activity Starred Repositories
Lukas Stockner commented on pull request blender/blender#123932 2024-06-30 23:46:26 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

Yeah, also fine.

Lukas Stockner suggested changes for blender/blender#123932 2024-06-30 22:38:15 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

Generally looks fine.

Lukas Stockner commented on pull request blender/blender#123932 2024-06-30 22:38:14 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

This (incl. the line above) could also be simplified to

Lukas Stockner commented on pull request blender/blender#123932 2024-06-30 22:38:13 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

Nitpick: sqr(dir.y) + sqr(dir.z).

Lukas Stockner commented on pull request blender/blender#123932 2024-06-30 22:31:03 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

@blender-bot build

Lukas Stockner approved blender/blender#123911 2024-06-30 22:23:25 +02:00
Cycles: Update device entries more often
Lukas Stockner commented on pull request blender/blender#123046 2024-06-30 22:22:55 +02:00
Cycles: add Central Cylindrical Panoramic camera model

@softyoda, just checking what the status here is. If you don't mind, I can make the remaining few changes as well.

Lukas Stockner approved blender/blender#123911 2024-06-28 20:38:23 +02:00
Cycles: Update device entries more often

There's a comment about this not being done more often due to OpenCL stability, so I think we're safe now to change this 😄

Lukas Stockner merged pull request blender/blender#123737 2024-06-28 20:33:48 +02:00
Fix and test direction_to_fisheye_lens_polynomial
Lukas Stockner pushed to main at blender/blender 2024-06-28 20:33:36 +02:00
fe54824f24 Fix and test direction_to_fisheye_lens_polynomial
Lukas Stockner approved blender/blender#123737 2024-06-28 20:30:57 +02:00
Fix and test direction_to_fisheye_lens_polynomial
Lukas Stockner closed issue blender/blender#122990 2024-06-28 16:31:39 +02:00
Color management: Easy way to define white point
Lukas Stockner commented on pull request blender/blender#123737 2024-06-28 16:27:36 +02:00
Fix and test direction_to_fisheye_lens_polynomial

@blender-bot build

Lukas Stockner commented on pull request blender/blender#123737 2024-06-28 14:56:51 +02:00
Fix and test direction_to_fisheye_lens_polynomial

@blender-bot build

Lukas Stockner commented on pull request blender/blender#123737 2024-06-28 13:50:24 +02:00
Fix and test direction_to_fisheye_lens_polynomial

@blender-bot build

Lukas Stockner approved blender/blender#123879 2024-06-28 11:29:09 +02:00
Fix #123876: Crash using eyedropper tool
Lukas Stockner commented on pull request blender/blender#123737 2024-06-28 11:28:23 +02:00
Fix and test direction_to_fisheye_lens_polynomial

@blender-bot build

Lukas Stockner commented on pull request blender/blender#123879 2024-06-28 11:21:32 +02:00
Fix #123876: Crash using eyedropper tool

I'd prefer setting but in the else body and then doing a nested if (but != nullptr) instead of this combination.

Lukas Stockner commented on pull request blender/blender#123737 2024-06-28 10:55:59 +02:00
Fix and test direction_to_fisheye_lens_polynomial

@blender-bot build

Lukas Stockner commented on pull request blender/blender#123737 2024-06-28 01:58:38 +02:00
Fix and test direction_to_fisheye_lens_polynomial

@blender-bot build