Lukas Tönne LukasTonne
Lukas Tönne commented on pull request blender/blender#108649 2023-06-08 13:38:05 +02:00
Nodes: Panel declarations for grouping sockets

@LukasTonne any reason they are called "node socket panells" rather than "node panels"?

The scope of this is a bit unclear. It started out as panels to organize sockets, if it's supposed to…

Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-08 13:04:13 +02:00
284a6bd094 Switch from arrays to ListBase for the categories in node trees.
Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-08 11:53:18 +02:00
3d1aae86c5 Merge branch 'main' into node-socket-categories
Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-08 11:39:11 +02:00
ebbd9629ac Merge branch 'main' into node-socket-categories
cfcf2cc3fa Merge branch 'blender-v3.6-release'
2387290e4f Fix #102737: Keyframe jump operator includes hidden curves in Graph Editor
40473db599 Merge branch 'blender-v3.6-release'
9e598aa0ef Fix #106395: Custom properties dont appear in quick favorites
Compare 67 commits »
Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-08 11:33:57 +02:00
f172423441 Cleanup: Rename "category" to "panel".
Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-08 11:18:28 +02:00
abae706c9b Cleanup: Rename "category" to "panel".
7b28d4c3f4 Merge branch 'main' into node-socket-categories
eb7ae2fb82 Merge branch 'blender-v3.6-release'
e3697710d0 Cycles: make light UV available for Texture Coordinate node
5399c7a79f BlendFile versioning: Fix mistake (inconsistency) in 8e059b569b.
Compare 85 commits »
Lukas Tönne commented on pull request blender/blender#108649 2023-06-07 15:45:04 +02:00
Nodes: Panel declarations for grouping sockets

I think these should be called "panels" rather than "socket categories"

I'm ok with "panel" too. It's a UI term, but since UI layout is the only thing we're going to use it for i think that's…

Lukas Tönne opened issue blender/blender#108703 2023-06-07 14:42:23 +02:00
Crash when loading asset libraries from within a large asset library
Lukas Tönne commented on pull request blender/blender#108649 2023-06-07 11:53:11 +02:00
Nodes: Panel declarations for grouping sockets

Ideally i'd like to display the node tree declarations in a way that resembles the final node output, to make it more intuitive. The vertical UI layout of the node editor sidebar makes that a bit…

Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-07 11:13:07 +02:00
4f0b237e50 Cleanup: remove some newlines.
Lukas Tönne commented on pull request blender/blender#108649 2023-06-07 11:12:56 +02:00
Nodes: Panel declarations for grouping sockets

Not sure, we may want to add more settings to categories, such as options to close categories by default, doc strings, etc.

Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-07 11:08:18 +02:00
530678fc8d Use std::copy for category add/remove/move methods.
df7713dcfc Use __func__ for MEM_malloc strings.
d7aa257d2d Cleanup: comment style fixes.
Compare 3 commits »
Lukas Tönne commented on pull request blender/blender#108649 2023-06-06 18:31:03 +02:00
Nodes: Panel declarations for grouping sockets

Not needed any more, sockets now store category UID instead of simple index, so category changes don't require remapping.

Lukas Tönne pushed to socket_subpanels at LukasTonne/blender 2023-06-06 18:26:26 +02:00
b9f98ec660 Revert "Return a simple bit data array for expand flags."
Lukas Tönne closed pull request blender/blender#108648 2023-06-06 18:15:33 +02:00
More flexible callback for persistent panel expand flags
Lukas Tönne commented on pull request blender/blender#108648 2023-06-06 18:15:30 +02:00
More flexible callback for persistent panel expand flags

Ok, i'm dropping it then, can revisit when we can actually do this in C++.

Lukas Tönne commented on pull request blender/blender#108648 2023-06-06 17:59:58 +02:00
More flexible callback for persistent panel expand flags

Sure, I'm just not sure that returning a pointer instead of a integer value helps prepare for BitVector more. Maybe until we can make this a C++ callback, it's better to use the value? It's…

Lukas Tönne pushed to socket_subpanels at LukasTonne/blender 2023-06-06 17:18:00 +02:00
cb1c379879 Merge branch 'node-socket-categories' into socket_subpanels
c7ab5dc068 Added a category_id identifier for stable Panel<->category relations.
73a45e94e3 Added a category_id identifier for stable Panel<->category relations.
Compare 3 commits »
Lukas Tönne pushed to node-socket-categories at LukasTonne/blender 2023-06-06 17:14:17 +02:00
c7ab5dc068 Added a category_id identifier for stable Panel<->category relations.
Lukas Tönne commented on pull request blender/blender#108649 2023-06-06 15:23:59 +02:00
Nodes: Panel declarations for grouping sockets

I want to add a simple int identifier to categories, so that after adding/removing/moving categories i can remap the expand flag bits. Otherwise these category actions will mess up the…