Mangal Kushwah Mangal-Kushwah
  • Joined on 2022-05-17
Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-05-16 07:10:50 +02:00
f179480817 Merge branch 'main' into operators-hidden-geometry
401401b7f2 GPv3: LinArt: Handle shared cache for v3.
66a338741e GPv3: LinArt: Missing walk() for `target_material`
672d203e67 Extensions: support file URI's for the remote URL
dd1769088b Fix error dropping a local extension onto Blender
Compare 1383 commits »
Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-05-16 07:02:07 +02:00
a3e2b45348 Cleanup
Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-05-01 17:06:35 +02:00
8e1b5724cd Refactor: gather_hidden_face_sets accesses face set attribute more directly
Mangal Kushwah commented on pull request blender/blender#119168 2024-04-28 12:27:24 +02:00
Fix #108105: Fix operators affecting hidden geometry

Thanks for visual explanation , It is working exactly like that. I have manually tested it so far everything is working as expected.

Mangal Kushwah commented on pull request blender/blender#119168 2024-04-26 12:23:17 +02:00
Fix #108105: Fix operators affecting hidden geometry

Removed it

Mangal Kushwah commented on pull request blender/blender#119168 2024-04-26 12:22:08 +02:00
Fix #108105: Fix operators affecting hidden geometry

Added the comment about invert

Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-04-26 12:20:31 +02:00
00c8a98250 Sculpt: Ensure visibility checks for mask slicing work in all cases
bed4956131 Refactor: Remove redundant line in geometry_extract_tag_masked_faces
Compare 2 commits »
Mangal Kushwah commented on pull request blender/blender#119168 2024-04-18 15:16:51 +02:00
Fix #108105: Fix operators affecting hidden geometry

Done

Mangal Kushwah commented on pull request blender/blender#119168 2024-04-06 17:11:31 +02:00
Fix #108105: Fix operators affecting hidden geometry

Why is the visibility only checked when !fill_holes ?

@Sergey I disabled visibility because of this (check the video).

I have some question:

  • Is this a bad thing?

  • If yes, do…

Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-04-03 17:57:02 +02:00
05b3797bc3 Refactor: Implement function to gather hidden face sets
917ae1c07d Merge branch 'main' into operators-hidden-geometry
8a1c2b172a Fix: Escape property name when keying
7400927ada Fix #120084: custom group node remains undefined after registering node type
04293e2494 Tools: Add script to report (high) priority issues per module
Compare 904 commits »
Mangal Kushwah commented on pull request blender/blender#119168 2024-04-02 17:41:52 +02:00
Fix #108105: Fix operators affecting hidden geometry

Will look into it tomorrow

Mangal Kushwah commented on pull request blender/blender#119168 2024-04-02 16:44:04 +02:00
Fix #108105: Fix operators affecting hidden geometry

Ok, Should I make it static?

Mangal Kushwah commented on pull request blender/blender#119168 2024-04-02 16:30:51 +02:00
Fix #108105: Fix operators affecting hidden geometry

Currently filling hole code does not take hidden geometry into account and because of this in some cases hidden part of geometry can be trapped inside mesh which i assumed is bad thing not…

Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-03-29 18:39:48 +01:00
c523317439 Ensure Mask Slice operations doesn't effect hidden faces
Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-03-29 14:40:04 +01:00
c79e279bd6 Ensure Mask Extract not create face for hidden faces
fd348ce083 Ensure face set from edit mode selction doesn't change hidden face sets
5ee36fe1f6 Ensure Intialize Face Set by Material doesn't alter hidden face sets
Compare 3 commits »
Mangal Kushwah commented on pull request blender/blender#119168 2024-03-28 12:02:11 +01:00
Fix #108105: Fix operators affecting hidden geometry

I'm confused for Face Sets by Materials would it be better if it can modify hidden geometry?

@HooglyBoogly @Sergey @JulienKaspar.

Mangal Kushwah commented on pull request blender/blender#119168 2024-03-28 11:53:21 +01:00
Fix #108105: Fix operators affecting hidden geometry

With this commit bpy.ops.sculpt.face_sets_init operations will not modify the hidden face sets, except Initialize Face Sets by Material.

I'm confused for Face Sets by Materials would it…

Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-03-28 11:39:05 +01:00
475a313561 Ensure sculpt_face_sets_init_flood_fill() doesn't alter hidden face sets
Mangal Kushwah created pull request blender/blender#119168 2024-03-07 16:07:02 +01:00
WIP Fix #108105: Fix operators that affect hidden geometry
Mangal Kushwah pushed to operators-hidden-geometry at Mangal-Kushwah/blender 2024-03-07 15:53:36 +01:00
82c531af36 Disable "Modifiy Hidden" property by default for Grow/Shrink, Fair or Delete face sets
5ab0cc8e74 Fix: Interpolation with clamped boundary returns zero
c8efea42e1 Cleanup: Remove unnecessary braces for container default constructors
d727738157 Cleanup: Comment formatting
c25a635587 Core: Avoid double map lookup in ID remapping
Compare 10 commits »