Marco-Rotili
0 Followers · 0 Following
  • Joined on 2024-10-25
Repositories
1
 Projects Public Activity Starred Repositories
Marco-Rotili closed pull request blender/blender#129763 2024-11-09 20:47:00 +01:00
Fix #129346: Applying modifier makes layers hierarchy lose track of group - layer relations.
Marco-Rotili commented on pull request blender/blender#129763 2024-11-09 20:46:56 +01:00
Fix #129346: Applying modifier makes layers hierarchy lose track of group - layer relations.

@filedescriptor Yes! I will close the PR.

Marco-Rotili commented on issue blender/blender#129346 2024-11-07 14:22:19 +01:00
Grease Pencil - Applying modifier makes layers hierarchy lose track of group - layer relations

@LukasTonne no worries - I agree :)

Marco-Rotili commented on pull request blender/blender#129758 2024-11-05 09:21:10 +01:00
Fix #129461: Sample index geometry node does not support Grease Pencil

@HooglyBoogly Sure!, Please find the file attached

Marco-Rotili commented on issue blender/blender#129346 2024-11-04 00:42:21 +01:00
Grease Pencil - Applying modifier makes layers hierarchy lose track of group - layer relations

I was able to reproduce the issue and I opened a PR with a fix. I think it is only a partial fix, as I don't fully understand yet how layers and layer groups can be changed using modifiers.

Marco-Rotili created pull request blender/blender#129763 2024-11-04 00:36:49 +01:00
Fix #129346: Applying modifier makes layers hierarchy lose track of group - layer relations.
8f3375ca2d Fix #129346: Applying modifier makes layers hierarchy lose track of group - layer relations.
43bbd9fd2d Fix: Paint: Unified strength value should be off by default
Compare 2 commits »
Marco-Rotili created pull request blender/blender#129758 2024-11-03 20:26:22 +01:00
Fix #129461: Sample index geometry node does not support Grease Pencil.
16464b5bf4 Fix #129461: Sample index geometry node does not support Grease Pencil.
470173bbc4 PyDoc: use keyword only specifier for bpy.props & bpy.ops
091ee2833b PyDoc: replace references to the deprecated "bgl" with "gpu"
b00550916c PyDoc: correct use of single back-ticks
901359abf7 Cleanup: replace doc-strings with comments for internal logic
Compare 18 commits »
f700a1c122 Fix formatting errors
Marco-Rotili commented on pull request blender/blender#129732 2024-11-02 22:32:31 +01:00
Fix #129629: Crash when applying Geometry Nodes modifier on all keyframes on a Grease Pencil object

I adapted the to use /* */, changed to third person and added a hashtag to the symbol reference. Let me know if I missed something!

a0dc07490f Fix comment style
Marco-Rotili commented on issue blender/blender#129461 2024-11-02 22:24:10 +01:00
Grease Pencil: Sample Index (Layer) raises an error and says Grease Pencil is an unsupported geometry type

I had a look at this. It looks like the sample index node does list the supported types. I added GeometryComponent::Type::GreasePencil and was able to create the geometry node graph without any…

Marco-Rotili commented on pull request blender/blender#129732 2024-11-02 22:20:03 +01:00
Fix #129629: Crash when applying Geometry Nodes modifier on all keyframes on a Grease Pencil object

Thanks for the feedback! I decided to retrieve the original modifier by calling BKE_modifier_get_original to avoid changing the signature of modifier_apply_obdata as the original modifier is…

d43f147c0a Fix #129629: Crash when applying Geometry Nodes modifier on all keyframes on a Grease Pencil object
44593efe28 Fix #129461: Sample index geometry node does not support Grease Pencil.
Marco-Rotili commented on issue blender/blender#129629 2024-11-02 21:23:51 +01:00
Crash when applying Geometry Nodes modifier on all keyframes on a Grease Pencil object

I was also able to reproduce the error and I provided a PR with a possible fix. I appreciate any feedback as I'm very new to blender.

Marco-Rotili created pull request blender/blender#129732 2024-11-02 21:23:02 +01:00
Fix #129629: Crash when applying Geometry Nodes modifier on all keyframes on a Grease Pencil object