Not sure about proper way to link things, but this issue is addressed by this PR: blender/blender#107149
I wonder if something more nuanced is needed here. Using the alpha channel for opacity generally makes sense, but I have also encountered materials that use a single-channel texture for opacity,…
Overall looks good to me, just a couple small changes recommended.
MEM_freeN aborts with an error if we attempt to free a null ptr. I think that can't happen here given current implementation, but given that the freeing of the object is so far separated from the allocation, I think it would be safer to only call MEM_freeN if non-null.
@Zhen-Dai please have another look with the official Blender 3.5 release or 3.6 betas.
This problem is fixed now, but to test it you will need to re-import the USDZ asset. If you simply open…
We fixed a very similar problem with blender/blender#105508, but apparently we missed another case where this happens. I will have a look.
Looks good to me, and confirmed it resolves the issue of missing colors in the viewport on my Mac.
@brecht, Yes, we should get this in 3.5 if possible. Apologies I missed the question earlier.
Looks good to me, with just small fix needed for compiling on Mac.
Is this a necessary change? Personally I find "i_point < last_point_index" more readable than points.drop_back(1).
The above three functions (check_catmullRom_curve, check_bezier_curve, check_nurbs_curve) need to be marked as static to match their definition below, otherwise this code does not compile with clang on macOS.
I recommend we close this issue, as it was fixed in blender/blender#104676.
I think we left this intentionally open-ended in case there may be other multiple aspects of USD export that still need to be tested, but we ended up addressing a significant part of this in the…