@makowalski Your updates look good to me, and I confirmed it works for the couple of test files.
Thank you @deadpin and @makowalski !
Michael, this is great point about animated displayColor attribute, thank you for adding this. I think it would be great to include here. Jesse, your…
LGTM, and also confirmed that this fixes the problem of keeping stale cached data when re-importing a modified USD file.
Not so important to me, but just observation that now that scene instances are supported, this reads rather strange, and it may be a good idea to change the name and meaning of the underlying variable.
Changing this behavior to false is clearly the correct thing to do, but I think the wording of this could be confusing. The way it is currently worded seems to imply that the proxies are something that exists in the asset being imported, and by turning the option off, you are choosing to not import some part of the asset. Some users may be tempted to just enable all the check boxes to ensure they are getting everything, which would of course be silly in this case.
@deadpin Hi Jesse, I think this means we should probably revert the factoring out into write_subdiv_and_normals, and go with our original implementation for that, as the subdiv scheme and…
Hi @deadpin , our assumption here is that the Subdivision scheme will never be animated, as we are not aware of any use cases where this would be desirable. I suggest we take this as a later…
Thanks for catching, I thought I had already changed this
@deadpin While comparing to usdview is a very reasonable thing in general, I have imagined the aim for Blender's importer functionality is different than for usdview. Probably we don't want…
@makowalski Sorry for the late replies here. @wave, Dhruv, and I discussed this PR several weeks ago and all agreed that it should move forward, specifically regarding treating the auto/non-specif…
Also note that we discovered the reason Blender was failing to find a prim in our problematic asset was not due to any issue in the USD file itself, but due to Blender limiting the max USD prim…
Confirmed, this is already addressed in @makowalski 's earlier PR: blender/blender#113524
As discussed, let's hold off on this. The bool !prim check should already be calling IsValid().
I pulled this PR and built locally, can confirm this is working well for me. I also confirmed that my asset round-tripped OK.
Using the code in this PR, I exported a test asset which exposes all six combinations of UV and geometry smoothing/interpolation options, so that the resulting USD output can be compared across…
@makowalski About taking evaluation mode into account for viewport vs render, that is a good catch, thanks, and thanks for the suggested code snippet. I think I just need a small change on that. …