Milan Davidović MilanDavidovic
0 Followers · 0 Following
  • Joined on 2023-09-10
Repositories
1
 Projects Public Activity Starred Repositories
Milan Davidović commented on pull request blender/blender#112688 2024-03-28 12:19:43 +01:00
Fix #106641: missing Annotation widgets

My pleasure :)

9a4dfa425d Fixed formatting.
Milan Davidović commented on pull request blender/blender#112688 2024-03-28 11:31:20 +01:00
Fix #106641: missing Annotation widgets

Thanks, make format didn't fix that one, I'll fix it now.

4faacc5478 Fixed formatting.
350d4ea176 Merge branch 'main' into fix-annotation-missing-widgets
362d381a5a Cleanup: pass GPUStateMutable as a const reference
e7abad23e0 Fix #118696: Nested override libraries can cause persistent resync warning.
b4517ca148 Cleanup: replace suspicious use of "&" with "&&"
0ef033750f Cleanup: pass arguments by const reference
Compare 6498 commits »
Milan Davidović commented on pull request blender/blender#112688 2024-03-28 10:19:41 +01:00
Fix #106641: missing Annotation widgets

Great, thanks!

Milan Davidović commented on pull request blender/blender#112688 2024-03-28 10:08:02 +01:00
Fix #106641: missing Annotation widgets

Just to check, I should merge main rather than rebase it and force push?

Milan Davidović commented on issue blender/blender#114196 2024-02-18 18:18:43 +01:00
Cycles don`t updated, when changes in color attributes is undo

I had a look at this. Undo and redo work if the Cycle window has the focus. I might try to fix this. Any useful tips?

365efa81fd Fix #106641: missing Annotation widgets
Milan Davidović commented on pull request blender/blender#112688 2024-02-06 13:40:08 +01:00
Fix #106641: missing Annotation widgets

Sure, I'll make the change. :)

Milan Davidović commented on pull request blender/blender#112688 2024-02-05 21:57:30 +01:00
Fix #106641: missing Annotation widgets

If I remember correctly, TOPBAR_PT_annotation_layers didn't work for Tools tab in Properties when I was first fixing this. That's why I added PROPERTIES_PT_annotation_layers, the only difference…

Milan Davidović commented on issue blender/blender#106641 2023-10-30 19:03:49 +01:00
UI: Annotate Tool - Missing Layer and Color Parameters

Missing Tool Settings menu item in Node editors isn't a bug after all: blender/blender#114205 (comment)

Since there's no way to see annotation…

Milan Davidović opened issue blender/blender#114205 2023-10-27 20:17:13 +02:00
Tool Settings menu item missing from View menu for Node editors
Milan Davidović commented on issue blender/blender#112683 2023-10-23 10:26:09 +02:00
context.annotation_data isn't set to nullptr when the last annotation layer is deleted

I believe so, but I'm not familiar with the procedure. @PratikPB2123?

989113c5b6 Removing the last Annotations layer produces a warning - improved comments.
388ff7c9c2 Fix #112683: Removing the last Annotations layer produces a warning.
e4134648b2 Fix #112683: Removing the last Annotations layer produces a warning.
ed619559ce Fix #113942: Cycles discontinuities in bump mapping
4e69e49e7e Add check for Qualcomm devices on Windows
Compare 255 commits »
Milan Davidović commented on issue blender/blender#106641 2023-10-16 14:56:46 +02:00
UI: Annotate Tool - Missing Layer and Color Parameters

I created the pull request, it's still not reviewed.

As for the missing Tool Settings menu item in Node editors, it should be a separate bug.

fc2375d8f6 Removing the last Annotations layer produces a warning - improved comments.
Milan Davidović commented on pull request blender/blender#113274 2023-10-11 13:18:26 +02:00
Fix #112683: Removing the last Annotations layer produces a warning.

Thanks Pratik, I'll make the change. Should I also change the comment in the other file?

72fd520603 Fix #112683: Removing the last Annotations layer produces a warning.
Milan Davidović commented on pull request blender/blender#113274 2023-10-09 22:58:23 +02:00
Fix #112683: Removing the last Annotations layer produces a warning.

Avoiding code duplication sounds good. BKE_gpencil_layer_delete would then have to take bGPdata **gpd though, so that it can null the correct pointer (&scene->gpd in `animchannels_delete_exec…