0
0
Fork 0
The official Blender project repository.
Go to file
Lukas Stockner 02a488d0fe Fix #61042: Cycles: Various Toon BSDF issues
The original bug report was that the Glossy Toon BSDF behaves incorrectly
when mixed with other closures.
The underlying issue here was that the eval function didn't check whether
the reflection angle is inside the valid cone and always returned its PDF,
which is very high compared to e.g. the diffuse closure's PDF for small
sizes (since the cone is supposed to be quite tight) and therefore breaks
MIS mixing.

However, while looking into this, I found a number of other issues, and so
this commit also contains several other changes to the Toon BSDFs:
- The angle that was used to compute the intensity wasn't the actual angle
  between the vectors. From what I can see, the formula that was used goes
  back all the way to the initial commit 12 years ago, so this probably was
  something that happened to work with one particular cone sampling method.
  Now, however, it caused weird asymmetric highlights, so replace it with
  the actual angle (which we already compute anyways).
- Setting size to zero caused the BSDF to go black, so clamp to 1e-5.
- The code was overall a bit repetitive, so I've cleaned it up a bit.
2024-03-24 23:52:16 +01:00
.gitea Revert "Experiment: Add release notes PR link field to pull request template" 2024-02-16 16:41:07 +01:00
.github Docs: Replace most wiki links with links to new developer docs 2024-01-18 16:49:38 +01:00
build_files Cleanup: remove unused variables 2024-03-21 10:11:54 +11:00
doc Merge branch 'blender-v4.1-release' 2024-03-22 12:28:46 +01:00
extern Extern libs: Remove info to update THIRD-PARTY-LICENSES 2024-03-19 17:06:31 +01:00
intern Fix #61042: Cycles: Various Toon BSDF issues 2024-03-24 23:52:16 +01:00
lib Merge branch 'blender-v4.1-release' 2024-03-16 19:45:51 +01:00
locale I18N: Updated UI translations from git/weblate (efe372a7b46cf). 2024-03-12 15:09:03 +09:00
release Cleanup: Move remaining GPU headers to C++ 2024-03-23 01:24:18 +01:00
scripts Fix #119816: New curves draw tool options missing in sidebar 2024-03-23 10:51:48 -04:00
source UI: Adjustments to Minimum Area Sizes 2024-03-24 19:40:18 +01:00
tests Fix #56355: Cycles: Wrong differentials for panoramic camera 2024-03-24 17:52:22 +01:00
tools Cleanup: remove unused variables 2024-03-21 10:11:54 +11:00
.clang-format Clang-Format: Ensure single new line at the end of files 2024-02-22 14:42:10 +01:00
.clang-tidy Clang-tidy: Ignore variable name length and .c/.cc include warnings 2022-05-06 15:26:54 +02:00
.editorconfig editorconfig: add HTML entry 2023-12-08 13:28:13 +11:00
.git-blame-ignore-revs Cleanup: add commit to .git-blame-ignore-revs 2023-05-03 20:31:11 +10:00
.gitignore Switch SVN to Git submodules using Git-LFS 2024-02-22 13:50:55 +01:00
.gitmodules Windows: Add ARM64 lib submodule 2024-03-14 18:12:51 +01:00
AUTHORS AUTHORS: add 7 new developers 2024-03-07 14:07:39 +11:00
CMakeLists.txt Cleanup: Centralize MSVC conformance related cmake items 2024-03-09 23:42:20 +01:00
COPYING == docs == 2010-10-13 14:44:22 +00:00
GNUmakefile Merge branch 'blender-v4.1-release' into main 2024-02-22 15:12:40 +01:00
README.md Docs: Replace most wiki links with links to new developer docs 2024-01-18 16:49:38 +01:00
make.bat Switch SVN to Git submodules using Git-LFS 2024-02-22 13:50:55 +01:00
pyproject.toml Black: skip string normalisation 2024-01-22 10:09:33 +01:00

README.md

Blender

Blender is the free and open source 3D creation suite. It supports the entirety of the 3D pipeline-modeling, rigging, animation, simulation, rendering, compositing, motion tracking and video editing.

Blender screenshot

Project Pages

Development

License

Blender as a whole is licensed under the GNU General Public License, Version 3. Individual files may have a different, but compatible license.

See blender.org/about/license for details.