Rob-Blair
  • Pennsylvania
  • Joined on 2023-07-29
Rob-Blair commented on pull request blender/blender#126309 2024-09-04 05:22:15 +02:00
Fix #125024 - Bevel offset - eliminate divide by 0

Thanks for looking at this. About the test failure, that's fine. As long as it's expected we can update the test file. However this diff adds a lot of complexity that I have a hard time…

Rob-Blair pushed to main at Rob-Blair/blender 2024-09-04 04:52:02 +02:00
e6ae281092 merge
5ebce65c6f Fix #125024 - Bevel offset - eliminate divide by 0
Compare 2 commits »
Rob-Blair pushed to main at Rob-Blair/blender 2024-08-31 05:37:17 +02:00
0feb2b9721 Fix #125024 - Bevel offset - eliminate divide by 0
Rob-Blair pushed to main at Rob-Blair/blender 2024-08-31 04:23:50 +02:00
428cf9fc14 Merge branch 'main' into Fix-bevel-offset
2b4c06f094 Fix #125024 - Bevel offset - eliminate divide by 0
ead0e2d1f8 Cleanup: Sculpt: Remove unnecessary default case statements
a08005f484 Docs: Update rna manual references
0df133559c Refactor: Store active_vert_ as ActiveVert not PBVHVertRef
Compare 137 commits »
Rob-Blair pushed to rob-blair-main at Rob-Blair/blender 2024-08-30 05:02:56 +02:00
b9636d3c73 Fix#125024 - Bevel offset - eliminate divide by 0
Rob-Blair created branch rob-blair-main in Rob-Blair/blender 2024-08-30 05:02:56 +02:00
Rob-Blair pushed to Rob-Blair-main at Rob-Blair/blender 2024-08-30 03:55:22 +02:00
36bd0c36a7 Fix #125024 - Bevel offset - eliminate divide by 0
5fba848dee Fix #125024 - Bevel offset - eliminate divide by 0
b019e4235a Cleanup: Standardize StrokeCache symmetry variable naming
ce0aafe3ef Cleanup: Remove unused SculptSession variable
2d6416454d Cleanup: Move vertex paint data out of stroke cache
Compare 10 commits »
Rob-Blair created branch Rob-Blair-main in Rob-Blair/blender 2024-08-30 03:55:22 +02:00
Rob-Blair deleted branch bevel-inner-arc-revision from Rob-Blair/blender 2024-08-28 03:39:15 +02:00
Rob-Blair deleted branch bevel-miter-inner-arc-slide from Rob-Blair/blender 2024-08-28 03:39:07 +02:00
Rob-Blair pushed to main at Rob-Blair/blender 2024-08-27 04:21:05 +02:00
a6438c683a Merge remote-tracking branch 'upstream/main'
bb24677a76 Cleanup: Rename CustomData_copy to CustomData_initi_from.
ea2f40748c Fix #122160: GPv3: Edit mode Undo memory leak.
b61e618886 Cleanup: Remove unused function
9c3eb49f8b Cleanup: Compositor: Generalize naming of shader operations
Compare 1069 commits »
Rob-Blair created branch bevel-inner-arc-revision in Rob-Blair/blender 2024-08-27 03:24:46 +02:00
Rob-Blair pushed to bevel-inner-arc-revision at Rob-Blair/blender 2024-08-27 03:24:46 +02:00
Rob-Blair created branch bevel-miter-inner-arc-slide in Rob-Blair/blender 2024-08-26 04:08:44 +02:00
Rob-Blair pushed to bevel-miter-inner-arc-slide at Rob-Blair/blender 2024-08-26 04:08:44 +02:00
Rob-Blair deleted branch bevel-inner-arc-revision from Rob-Blair/blender 2024-08-26 04:07:46 +02:00
Rob-Blair created branch bevel-offset in Rob-Blair/blender 2024-08-26 04:07:46 +02:00
Rob-Blair created branch bevel-inner-arc-revision in Rob-Blair/blender 2024-08-26 03:24:29 +02:00
Rob-Blair pushed to bevel-inner-arc-revision at Rob-Blair/blender 2024-08-26 03:24:29 +02:00
Rob-Blair commented on issue blender/blender#123521 2024-08-18 04:33:39 +02:00
Bevel segments added to incorrect edges when using Miter Inner Arc

I believe the problem is in bmesh_bevel.cc the "adjust_miter_inner_coords" function adds a sideways bevel offset, "spread," that is not checked regarding clamp overlap. Without accounting for…