Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#125525 2024-07-29 18:42:56 +02:00
Sculpt: Partial refactor of boundary brush

If that's convention then I'll switch the file to do this - though I do believe that in general readability is improved if you consider how files are usually read from top to bottom. We don't have…

Sean Kim commented on pull request blender/blender#125525 2024-07-29 18:27:44 +02:00
Sculpt: Partial refactor of boundary brush

In this particular case, I think it helps organize the file a bit better, letting the data_init function be one of the first things you read.

Sean Kim commented on pull request blender/blender#125525 2024-07-29 16:14:22 +02:00
Sculpt: Partial refactor of boundary brush

As a side note, if you decide to test this PR locally, the default Bend deformation type behaves extremely weird for both Dyntopo and Multires

But this isn't something this PR…

Sean Kim commented on pull request blender/blender#125525 2024-07-29 09:58:21 +02:00
Sculpt: Partial refactor of boundary brush

Note to self to remove this extra unique_ptr - it's likely causing an extra allocation here.

Sean Kim pushed to main at Sean-Kim/.profile 2024-07-29 05:56:37 +02:00
0a73cdeefe Update reports/2024.md
Sean Kim pushed to main at Sean-Kim/.profile 2024-07-28 10:11:33 +02:00
1d967b3761 Update reports/2024.md
Sean Kim pushed to closest-boundary-vert at Sean-Kim/blender 2024-07-27 09:29:33 +02:00
758227c0dc Update comment
Sean Kim commented on pull request blender/blender#125525 2024-07-27 06:42:52 +02:00
Sculpt: Partial refactor of boundary brush

The original code going back to when this brush was first implemented also uses initial_vert here for this check instead of boundary_initial_vert, despite the intention seemingly being to check the found boundary. I haven't done adequate testing to determine if this change should actually be made yet.

Sean Kim created pull request blender/blender#125525 2024-07-27 06:34:05 +02:00
Sculpt: Partial refactor of boundary brush
Sean Kim pushed to closest-boundary-vert at Sean-Kim/blender 2024-07-27 06:32:26 +02:00
3052a93c8b Sculpt: Partial refactor of boundary brush
2f15347f7c Fix: Empty span check for vert_all_faces_visible_get
e8c7fe8ab9 Fix: Out of bounds errors with FillDataMesh
e974ee05dc Cleanup: clarify ED_markers_make_cfra_list only selected argument
80f135e7d2 Cleanup: avoid shadowing
Compare 8 commits »
Sean Kim deleted branch fix-vert-all-faces-visible from Sean-Kim/blender 2024-07-27 06:16:34 +02:00
Sean Kim pushed to main at blender/blender 2024-07-27 06:16:31 +02:00
2f15347f7c Fix: Empty span check for vert_all_faces_visible_get
Sean Kim merged pull request blender/blender#125524 2024-07-27 06:16:31 +02:00
Fix: Empty span check for vert_all_faces_visible_get
Sean Kim deleted branch fix-flood-fill from Sean-Kim/blender 2024-07-27 06:15:56 +02:00
Sean Kim merged pull request blender/blender#125523 2024-07-27 06:15:53 +02:00
Fix: Out of bounds errors with FillDataMesh
Sean Kim pushed to main at blender/blender 2024-07-27 06:15:53 +02:00
e8c7fe8ab9 Fix: Out of bounds errors with FillDataMesh
Sean Kim deleted branch span-comment-cleanup from Sean-Kim/blender 2024-07-27 05:28:17 +02:00
Sean Kim merged pull request blender/blender#125512 2024-07-27 05:28:15 +02:00
Cleanup: Fix Span drop_back docstring
Sean Kim pushed to main at blender/blender 2024-07-27 05:28:14 +02:00
edb73325c1 Cleanup: Fix Span drop_back docstring
Sean Kim commented on pull request blender/blender#125524 2024-07-27 05:18:38 +02:00
Fix: Empty span check for vert_all_faces_visible_get