Just as a note here - while this won't crash anymore, this has likely never behaved in the way one would expect with an eyedropper; it is only able to sample from the currently active sculpt object
Closing for now then; feel free to reopen or create a new issue if you can reproduce this again.
This seems reasonable - only thought I had was if we want to use the "last active vertex" that was introduced for the expand operator, but I'm on the fence as to whether that's as important here. I think in this case it's valid to just cancel the operation
Wasn't entirely certain who to tag for review for this, just took a stab in the dark since Brecht is still on sabbatical and he worked on the code being modified here
Have a PR that appears to fix this issue, will publish shortly.
I think the ideal fix here is probably to base the relative path off of the .blend file of the brush and not of the current active .blend file,
Behavior was introduced with the brush assets merge (7b0ea0f1b4) (Needed to cherry-pick bbcc720c13283f076191573d11a43a04a891f1c6
to avoid a crash when in the UI)
CC: @JulianEisel
Can confirm behavior on Mac as well - looking into bisecting just to verify my previous assumption
Currently just trying to get the python side of things working (the .setup
method). As is, the code currently crashes immediately upon startup due to an ASAN heap buffer overflow inside…