Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim created pull request blender/blender#125277 2024-07-23 07:02:29 +02:00
Cleanup: Replace GSet with blender::Set in sculpt_boundary.cc
Sean Kim pushed to replace-gset at Sean-Kim/blender 2024-07-23 07:02:09 +02:00
9605ed421c Cleanup: Replace GSet with blender::Set in sculpt_boundary.cc
Sean Kim created branch replace-gset in Sean-Kim/blender 2024-07-23 07:02:09 +02:00
Sean Kim commented on issue blender/blender#125249 2024-07-23 06:12:20 +02:00
Inconsistency: Polyline tools in Sculpt mode do not react to double click.

Marking this as a to-do - the initial design of the polyline mode was to have clicking on the start position & pressing Enter as the only ways to submit the shape, but I think that consistency…

Sean Kim created pull request blender/blender#125274 2024-07-23 06:03:51 +02:00
Refactor: Switch vector of PBVHVertRef in SculptBoundary for int
Sean Kim created branch pbvhvertref-to-index in Sean-Kim/blender 2024-07-23 06:01:31 +02:00
Sean Kim pushed to pbvhvertref-to-index at Sean-Kim/blender 2024-07-23 06:01:31 +02:00
f17d8e4356 Refactor: Switch vector of PBVHVertRef in SculptBoundary for int
Sean Kim commented on pull request blender/blender#125273 2024-07-23 05:13:37 +02:00
Refactor: Remove SculptBoundary initial_vert field
Sean Kim created pull request blender/blender#125273 2024-07-23 05:13:08 +02:00
Refactor: Remove SculptBoundary initial_vert field
Sean Kim pushed to remove-pbvhvertref-sculpt-boundary at Sean-Kim/blender 2024-07-23 05:12:38 +02:00
3448a1880d Refactor: Remove SculptBoundary initial_vert field
Sean Kim created branch remove-pbvhvertref-sculpt-boundary in Sean-Kim/blender 2024-07-23 05:12:37 +02:00
Sean Kim commented on pull request blender/blender#125268 2024-07-23 03:28:20 +02:00
Fix #125157: Sculpt multires crashes on box mask and duplicated stroke

An alternative here is to apply the following fix to simply ignore this update for multires, I'm currently undecided if this seems less risky & worth doing. It has the benefit of keeping curve…

Sean Kim commented on pull request blender/blender#125268 2024-07-23 02:38:17 +02:00
Fix #125157: Sculpt multires crashes on box mask and duplicated stroke

For more information, the unreported issue that's alluded to in the original post of this PR is likely a race condition that I missed encountering when testing the initial implementation. That…

Sean Kim created pull request blender/blender#125268 2024-07-23 02:33:15 +02:00
Revert "Fix #122947: Curve stroke on duplicate object doesn't update normals"
Sean Kim pushed to fix-125157 at Sean-Kim/blender 2024-07-23 02:26:23 +02:00
7cb142e61d Revert "Fix #122947: Curve stroke on duplicate object doesn't update normals"
90e83175eb Fix #125168: Cycles spot light theata_e can flip with a wide spread
f2c728468c Cleanup: Fix warnings
07c613b485 Cleanup: Adjust GSpan and GArray asserts
27c877f684 Fix: GPv3: Use of legacy object type in shaderfx_add
Compare 10 commits »
Sean Kim created branch fix-125157 in Sean-Kim/blender 2024-07-23 02:26:22 +02:00
Sean Kim commented on issue blender/blender#125157 2024-07-23 01:02:38 +02:00
Box mask crashes Blender in sculpt mode

In 4.3, the BKE_sculpt_update_object_before_eval method isn't called at all. I'm not sure what changed with the depsgraph updates

Sean Kim commented on issue blender/blender#125157 2024-07-22 16:48:32 +02:00
Box mask crashes Blender in sculpt mode

Regression was introduced here: d527e3a6bd

Sean Kim commented on issue blender/blender#125157 2024-07-22 16:41:47 +02:00
Box mask crashes Blender in sculpt mode

Stack trace:

mul_v3_v3fl(float * r, const float * a, float f) (/home/skim/Projects/blender-git/blender/source/blender/blenlib/intern/math_vector_inline.c:562)
subdiv_ccg_average_inner_face…