Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim deleted branch pivot-vertex-cleanup from Sean-Kim/blender 2024-07-16 04:20:44 +02:00
Sean Kim pushed to main at blender/blender 2024-07-16 04:20:43 +02:00
cf656ac040 Refactor: Use float3 instead of PBVHVertRef for pivot_vertex
Sean Kim merged pull request blender/blender#124755 2024-07-16 04:20:42 +02:00
Refactor: Use float3 instead of PBVHVertRef for pivot_vertex
Sean Kim pushed to pivot-vertex-cleanup at Sean-Kim/blender 2024-07-16 04:12:00 +02:00
21156c0950 Add missed line
Sean Kim pushed to pivot-vertex-cleanup at Sean-Kim/blender 2024-07-16 04:05:37 +02:00
6bb041fb65 Rename pivot_vert, remove initial_pivot_position
a9845c80bd Merge branch 'main' of projects.blender.org:blender/blender into pivot-vertex-cleanup
c20b8f5d6e Refactor: Replace SculptBoundaryPreviewEdge with std::pair
e30a1326a4 Fix #124719: Failed assert in old (2.34) testfile
e35e80275a Cleanup: Formatting
Compare 63 commits »
Sean Kim deleted branch boundary-brush-refactor from Sean-Kim/blender 2024-07-16 03:41:17 +02:00
Sean Kim pushed to main at blender/blender 2024-07-16 03:41:12 +02:00
c20b8f5d6e Refactor: Replace SculptBoundaryPreviewEdge with std::pair
Sean Kim merged pull request blender/blender#124754 2024-07-16 03:41:12 +02:00
Refactor: Replace SculptBoundaryPreviewEdge with std::pair
Sean Kim commented on pull request blender/blender#124754 2024-07-16 02:48:03 +02:00
Refactor: Replace SculptBoundaryPreviewEdge with std::pair

Best case this optimization that was removed only provided a performance benefit if it just so happened that the active vertex didn't update between brush strokes. If you think this needs further…

Sean Kim pushed to boundary-brush-refactor at Sean-Kim/blender 2024-07-16 02:39:57 +02:00
4965ff1e24 Remove conditional boundary data update logic
Sean Kim commented on pull request blender/blender#124754 2024-07-16 02:03:26 +02:00
Refactor: Replace SculptBoundaryPreviewEdge with std::pair

Ugh, this actually is insufficient. This causes the preview to get glitched out

Sean Kim commented on pull request blender/blender#124756 2024-07-16 01:46:52 +02:00
Cleanup: Reduce usage of initial_vert

Actually, marking this one as WIP, I think this particular position might not be stable & this PR might change behavior

Sean Kim created pull request blender/blender#124756 2024-07-16 01:44:32 +02:00
Cleanup: Reduce usage of initial_vert
Sean Kim pushed to boundary-initial-vert-cleanup at Sean-Kim/blender 2024-07-16 01:39:38 +02:00
e66a623aeb Cleanup: Reduce usage of initial_vert
Sean Kim created branch boundary-initial-vert-cleanup in Sean-Kim/blender 2024-07-16 01:39:38 +02:00
Sean Kim created pull request blender/blender#124755 2024-07-16 01:34:52 +02:00
Cleanup: Use float3 instead of PBVHVertRef for pivot_vertex
Sean Kim created branch pivot-vertex-cleanup in Sean-Kim/blender 2024-07-16 01:33:51 +02:00
Sean Kim pushed to pivot-vertex-cleanup at Sean-Kim/blender 2024-07-16 01:33:51 +02:00
e36e9db306 Cleanup: Use float3 instead of PBVHVertRef for pivot_vertex
Sean Kim created pull request blender/blender#124754 2024-07-16 01:20:24 +02:00
Cleanup: Replace SculptBoundaryPreviewEdge with std::pair
Sean Kim pushed to boundary-brush-refactor at Sean-Kim/blender 2024-07-16 01:19:38 +02:00
760eb2c623 Cleanup: Replace SculptBoundaryPreviewEdge with std::pair