Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim created pull request blender/blender#124633 2024-07-12 23:20:52 +02:00
Sculpt: Initial data oriented refactor of topology relax brush
Sean Kim pushed to topology-relax-brush-refactor at Sean-Kim/blender 2024-07-12 23:17:40 +02:00
863f6dcdd6 Fix parameter passing, remove restore step filter
0352649b9e Merge branch 'main' of projects.blender.org:blender/blender into topology-relax-brush-refactor
178966b0ba Fix: Draw Sharp and Topology Slide use incorrect position data
f03b35e669 Fix: Relax Face Set deform & shape key extra application
2ca366827c Cleanup: Space_node.cc static_casts
Compare 40 commits »
Sean Kim suggested changes for blender/blender#124569 2024-07-12 22:59:34 +02:00
Sculpt: Data oriented refactor for enhance details brush

Didn't do any actual testing of this build locally, just reviewed the code.

Sean Kim commented on pull request blender/blender#124569 2024-07-12 22:59:33 +02:00
Sculpt: Data oriented refactor for enhance details brush

I think we need isolate_task here, since we use the array_utils::scatter

Sean Kim commented on pull request blender/blender#124569 2024-07-12 22:59:32 +02:00
Sculpt: Data oriented refactor for enhance details brush

Nit: The name all_nodes is a bit misleading in my opinion

Sean Kim commented on pull request blender/blender#124569 2024-07-12 22:59:31 +02:00
Sculpt: Data oriented refactor for enhance details brush

I'm not sure if I'm missing something here, but I think this can be incorrectly indexed since all_translations no longer matches the full number of verts in the mesh?

Sean Kim commented on pull request blender/blender#124569 2024-07-12 22:59:29 +02:00
Sculpt: Data oriented refactor for enhance details brush

Similar as above, but due to gather

Sean Kim commented on pull request blender/blender#124569 2024-07-12 22:59:28 +02:00
Sculpt: Data oriented refactor for enhance details brush

Nit: Seems a bit odd to specify array when this works for any span - maybe just gather_grids_data and rename array -> src?

Sean Kim commented on pull request blender/blender#124569 2024-07-12 22:02:37 +02:00
Sculpt: Data oriented refactor for enhance details brush

Unrelated to the actual code - this PR has had a broken warning for missing fork information for a bit now; was expecting it to go away eventually but it might be something you need to look into?

Sean Kim deleted branch fix-draw-sharp from Sean-Kim/blender 2024-07-12 20:59:39 +02:00
Sean Kim merged pull request blender/blender#124572 2024-07-12 20:59:23 +02:00
Fix: Draw Sharp and Topology Slide use incorrect position data
Sean Kim pushed to main at blender/blender 2024-07-12 20:59:22 +02:00
178966b0ba Fix: Draw Sharp and Topology Slide use incorrect position data
Sean Kim pushed to fix-draw-sharp at Sean-Kim/blender 2024-07-12 20:57:32 +02:00
f220e726d1 Fix parameters for clip factors
Sean Kim deleted branch fix-flush from Sean-Kim/blender 2024-07-12 20:47:43 +02:00
Sean Kim merged pull request blender/blender#124573 2024-07-12 20:47:40 +02:00
Fix: Relax Face Set deform & shape key extra application
Sean Kim pushed to main at blender/blender 2024-07-12 20:47:40 +02:00
f03b35e669 Fix: Relax Face Set deform & shape key extra application
Sean Kim created branch topology-relax-brush-refactor in Sean-Kim/blender 2024-07-12 08:05:54 +02:00
Sean Kim pushed to topology-relax-brush-refactor at Sean-Kim/blender 2024-07-12 08:05:54 +02:00
c60ac92eda Cleanup warnings
d8cb612794 Sculpt: Initial data oriented refactor of topology relax brush
Compare 2 commits »
Sean Kim pushed to fix-draw-sharp at Sean-Kim/blender 2024-07-12 07:19:17 +02:00
d732134e3c Use orig data for clip factor filter
Sean Kim created pull request blender/blender#124573 2024-07-12 06:56:31 +02:00
Fix: Relax Face Set deform & shape key extra application