Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#124439 2024-07-10 02:41:56 +02:00
Cleanup: SubdivCCG: Prevent copying of SubdivCCG

@blender-bot build

Sean Kim created pull request blender/blender#124439 2024-07-10 02:41:41 +02:00
Refactor: SubdivCCG: Prevent copying of SubdivCCG
Sean Kim pushed to noncopyable-subdiv-ccg at Sean-Kim/blender 2024-07-10 02:41:09 +02:00
58b11e8fba Refactor: SubdivCCG: Prevent copying of SubdivCCG
Sean Kim created branch noncopyable-subdiv-ccg in Sean-Kim/blender 2024-07-10 02:41:09 +02:00
Sean Kim pushed to relax-face-set-brush-refactor at Sean-Kim/blender 2024-07-10 02:27:30 +02:00
e962eb9273 Move unreachable assert
47ed298f2b Fix various multires issues
Compare 2 commits »
Sean Kim pushed to relax-face-set-brush-refactor at Sean-Kim/blender 2024-07-09 23:04:02 +02:00
c5e9f85dc0 Compilation
Sean Kim pushed to relax-face-set-brush-refactor at Sean-Kim/blender 2024-07-09 05:07:12 +02:00
ab3641cb4e Multires progress
fe563e5402 Merge branch 'main' of projects.blender.org:blender/blender into relax-face-set-brush-refactor
e474eef5d1 Cleanup: Formatting
28d3f7f638 Cleanup: Sculpt: Remove unused PBVH variables
4817ff1d72 Refactor: Sculpt: Remove PBVH CCGKey storage
Compare 233 commits »
Sean Kim pushed to relax-face-set-brush-refactor at Sean-Kim/blender 2024-07-08 23:25:39 +02:00
93181737f0 Restructure factor & translation calculation
b983ef73bf Rename variable
99795ad144 Extract neighbor filtering logic
053a2de9d1 WIP
d37cdceb5c Rename variable
Compare 7 commits »
Sean Kim approved blender/blender#124371 2024-07-08 22:55:17 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires
Sean Kim commented on pull request blender/blender#124371 2024-07-08 22:51:05 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires

Actually, just noticed this assert being wrong too

Sean Kim suggested changes for blender/blender#124371 2024-07-08 22:36:06 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires

Generally looks fine, think I spot one compilation-blocking typo though

Sean Kim commented on pull request blender/blender#124371 2024-07-08 22:36:05 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires

vert_neighbors -> verts?

Sean Kim commented on pull request blender/blender#124371 2024-07-08 22:36:04 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires

const here and elsewhere

Sean Kim commented on pull request blender/blender#124371 2024-07-08 22:36:03 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires

Not sure if it's worth documenting that we do this in a separate loop because of the potential node-crossing, just noticed the disconnect from the grid implementation

Sean Kim commented on pull request blender/blender#124371 2024-07-08 22:36:02 +02:00
Sculpt: Refactor position and mask smoothing for BMesh and multires

Nit:

Sean Kim deleted branch expose-translate-helper from Sean-Kim/blender 2024-07-08 22:10:12 +02:00
Sean Kim pushed to main at blender/blender 2024-07-08 22:10:10 +02:00
c070986e23 Cleanup: Sculpt: Extract common translation function
Sean Kim merged pull request blender/blender#124368 2024-07-08 22:10:09 +02:00
Cleanup: Sculpt: Extract common translation function
Sean Kim pushed to expose-translate-helper at Sean-Kim/blender 2024-07-08 22:01:38 +02:00
79be819350 Whitespace
Sean Kim created pull request blender/blender#124368 2024-07-08 21:48:13 +02:00
Cleanup: Sculpt: Extract common translation function