Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim pushed to face-set-brush-refactor at Sean-Kim/blender 2024-07-03 04:48:35 +02:00
cb8f2eaeae Make similar refactoring changes for Bmesh
bdb1edea20 Remove unused struct variable
c693c11e08 Reorder undo push
7fc3a98f63 Remove unused tls variables
62e7352d24 Refactor face calculation methods
Compare 9 commits »
Sean Kim commented on pull request blender/blender#123811 2024-07-03 04:26:42 +02:00
Sculpt: Initial data oriented refactor for draw face sets brush

It works different enough that switching to bke::pbvh::node_face_indices_calc_grids causes this to stop working, unless I'm mistaken. What we need here is a map from grid vert to base mesh face…

Sean Kim commented on pull request blender/blender#123811 2024-07-03 02:37:25 +02:00
Sculpt: Initial data oriented refactor for draw face sets brush

I added an assert in apply_face_sets on the size - it's not tripping up and it seems to be working as expected.

It's getting the factor from a given grid vert, mapping it via the `face_indic…

Sean Kim commented on pull request blender/blender#123811 2024-07-03 02:28:11 +02:00
Sculpt: Initial data oriented refactor for draw face sets brush

Ah, you're right, this currently causes the brush to not work while automasking is enabled.

Sean Kim pushed to face-set-brush-refactor at Sean-Kim/blender 2024-07-03 01:52:34 +02:00
414a140221 Fix mask calculation, reorganize and add const
8d1ce0d7d7 Merge branch 'main' of projects.blender.org:blender/blender into face-set-brush-refactor
778ef300cd BMesh implementation
e26e62597d Cleanup: Sculpt: Use C++ math types/functions in displacement smear
4763aeff9e Cleanup: Sculpt: Specialize displacement smear vertex neighbor iteration
Compare 69 commits »
Sean Kim opened issue blender/blender#124066 2024-07-02 22:30:25 +02:00
Dyntopo Draw Face Set ignores mask values
Sean Kim opened issue blender/blender#124065 2024-07-02 22:27:06 +02:00
Dyntopo Draw Face Set changes base mesh color on first stroke
Sean Kim commented on issue blender/blender#124045 2024-07-02 15:50:23 +02:00
Python errors when cutting node links

Should be fixed with this PR: blender/blender#124040

Sean Kim approved blender/blender#124040 2024-07-02 15:24:31 +02:00
Fix #124045: Console error when using node gesture operation

Ah, thanks for the fix, looks good to me.

Sean Kim pushed to face-set-brush-refactor at Sean-Kim/blender 2024-07-02 01:53:16 +02:00
d1a3ab8344 Multires
478177f2aa Merge branch 'main' of projects.blender.org:blender/blender into face-set-brush-refactor
11db18473d Refactor: Sculpt: Split up smooth::relax_vertex
4b03274d80 Cleanup: Sculpt: Split function to join multi-plane samples, rename struct
3f27917838 Cleanup: Tweak variable naming in multiplane scrape brush
Compare 188 commits »
Sean Kim deleted branch more-more-forward-declarations from Sean-Kim/blender 2024-07-02 00:47:00 +02:00
Sean Kim pushed to main at blender/blender 2024-07-02 00:46:57 +02:00
9fbfce4a13 Cleanup: Sculpt: Add forward declarations
Sean Kim merged pull request blender/blender#124017 2024-07-02 00:46:57 +02:00
Cleanup: Sculpt: Add forward declarations
Sean Kim created pull request blender/blender#124017 2024-07-02 00:16:08 +02:00
Cleanup: Sculpt: Add forward declarations
Sean Kim pushed to more-more-forward-declarations at Sean-Kim/blender 2024-07-02 00:15:29 +02:00
70ae1c5acb Cleanup: Sculpt: Add forward declarations
11db18473d Refactor: Sculpt: Split up smooth::relax_vertex
4b03274d80 Cleanup: Sculpt: Split function to join multi-plane samples, rename struct
3f27917838 Cleanup: Tweak variable naming in multiplane scrape brush
29ce7907e2 Cleanup: Sculpt: Simplify access to multiplane scrape planes
Compare 10 commits »
Sean Kim created branch more-more-forward-declarations in Sean-Kim/blender 2024-07-02 00:15:28 +02:00
Sean Kim deleted branch relax-vertex-cleanup from Sean-Kim/blender 2024-07-01 23:43:33 +02:00
Sean Kim pushed to main at blender/blender 2024-07-01 23:43:28 +02:00
11db18473d Refactor: Sculpt: Split up smooth::relax_vertex
Sean Kim merged pull request blender/blender#124014 2024-07-01 23:43:28 +02:00
Refactor: Sculpt: Split up smooth::relax_vertex