Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#123703 2024-06-27 02:37:04 +02:00
Sculpt: Extend refactor to change multires in brushes

Is there a way for us to remove the if here and just convert hidden[offset] into the appropriate value? Not sure if it would have a significant impact on performance in the Mask brush.

Sean Kim commented on pull request blender/blender#123703 2024-06-27 02:37:03 +02:00
Sculpt: Extend refactor to change multires in brushes

Is the idea here from switching away from BKE_pbvh_get_grid_key to the raw BKE_subdiv_ccg_key_top_level to make way for removing more data from the PBVH?

Sean Kim deleted branch refactor-orig-vert-data from Sean-Kim/blender 2024-06-27 01:42:33 +02:00
Sean Kim merged pull request blender/blender#123755 2024-06-27 01:42:31 +02:00
Refactor: Sculpt: Use return value instead of reference for orig_data
Sean Kim pushed to main at blender/blender 2024-06-27 01:42:30 +02:00
6b7255b978 Refactor: Sculpt: Use return value instead of reference for orig_data
Sean Kim deleted branch lasso-stabilize from Sean-Kim/blender 2024-06-27 01:32:30 +02:00
Sean Kim merged pull request blender/blender#122062 2024-06-27 01:32:27 +02:00
Sculpt: Add stroke stabilization to lasso tools
Sean Kim pushed to main at blender/blender 2024-06-27 01:32:27 +02:00
9d4d1aea98 Sculpt: Add stroke stabilization to lasso tools
Sean Kim closed pull request blender/blender#123760 2024-06-27 01:25:01 +02:00
WIP: Refactor: Remove extra node mark calls
Sean Kim commented on pull request blender/blender#123760 2024-06-27 01:24:59 +02:00
WIP: Refactor: Remove extra node mark calls

Closing this, since we aren't moving in this direction for the overall brush refactor.

Sean Kim closed pull request blender/blender#123524 2024-06-27 01:23:57 +02:00
Fix: Prevent debug assert when switching to Sculpt Mode
Sean Kim commented on pull request blender/blender#123524 2024-06-27 01:23:54 +02:00
Fix: Prevent debug assert when switching to Sculpt Mode

Closing this - Any changes that I would propose to make as cleanup here would probably be in separate commits or other PRs.

Sean Kim commented on pull request blender/blender#123760 2024-06-26 02:29:01 +02:00
WIP: Refactor: Remove extra node mark calls

Makes sense, wasn't sure which direction we were going here in terms of abstraction; I suppose the larger idea for push_undo_nodes is to also move the undo steps along with the node marking, right?

Sean Kim created pull request blender/blender#123760 2024-06-26 01:27:05 +02:00
WIP: Refactor: Remove extra node mark calls
Sean Kim pushed to refactor-remove-positions-update at Sean-Kim/blender 2024-06-26 01:26:00 +02:00
3a0911a91c Refactor: Remove extra node mark calls
Sean Kim created branch refactor-remove-positions-update in Sean-Kim/blender 2024-06-26 01:26:00 +02:00
Sean Kim commented on pull request blender/blender#123755 2024-06-25 23:10:52 +02:00
Refactor: Sculpt: Use return value instead of reference for orig_data

@blender-bot build

Sean Kim created pull request blender/blender#123755 2024-06-25 23:10:33 +02:00
Refactor: Use return value instead of reference for orig_data
Sean Kim created branch refactor-orig-vert-data in Sean-Kim/blender 2024-06-25 23:10:06 +02:00
Sean Kim pushed to refactor-orig-vert-data at Sean-Kim/blender 2024-06-25 23:10:06 +02:00
aae7978e21 Refactor: Use return value instead of reference for orig_data