Minor nit: It seems like the only reason we pass down the entire Sculpt object is so we can access the .flags for clipping - do we want to extract this somehow?
We can just skip
SculptOrigVertDatacompletely, usingSpan<float3> positions = undo::get_node(...)->position
My only issue with this is that I think having an explicit named method like…
Just a general note, I think it's probably better if we don't add overloads of these calc methods to pass in SculptOrigVertData - I think there should be a way to get a Span from the raw float3 pointer
I think this function is actually not needed for the color / mask smoothing cases, judging from the existing code in draw_smooth. I think I'll expose a similar neighbor function that doesn't need to consider boundary verts
Oh, yeah. This is something that I'll definitely fix
It might be better to just include the necessary headers here. We can then split this header later if necessary. We discussed this a bit a while back and thought it might be better to have…