Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:59 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

radius and mat can be moved here

Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:58 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

temp, area_co, displace, and area_co can be moved to just above here

Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:57 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

I think it's probably worth cleaning up some of these short names during this.

Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:56 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

Might be worth modernizing the vectors and matricies here where we can

Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:55 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

Not sure if we want to do this now or later, but maybe it's worth pulling these "write" functions out into a common helper? I don't see this particular block of calls changing much.

Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:54 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

I think we should extract most of the code before here into a separate static helper function that just returns the mat, since most other variables just seem to be for temporary calculation.

Sean Kim commented on pull request blender/blender#123154 2024-06-13 00:00:53 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

scale and tmat can be moved here

Sean Kim deleted branch cleanup-namespace from Sean-Kim/blender 2024-06-12 22:45:53 +02:00
Sean Kim pushed to main at blender/blender 2024-06-12 22:45:51 +02:00
ad3c92b660 Cleanup: Remove unnecessary namespace specification
Sean Kim merged pull request blender/blender#123153 2024-06-12 22:45:50 +02:00
Cleanup: Remove unnecessary namespace specification
Sean Kim created pull request blender/blender#123153 2024-06-12 22:42:40 +02:00
Cleanup: Remove unnecessary namespace specification
Sean Kim pushed to cleanup-namespace at Sean-Kim/blender 2024-06-12 22:42:15 +02:00
cf26784489 Cleanup: Remove unnecessary namespace specification
Sean Kim created branch cleanup-namespace in Sean-Kim/blender 2024-06-12 22:42:15 +02:00
Sean Kim commented on pull request blender/blender#123115 2024-06-12 22:34:34 +02:00
Sculpt: Initial data-oriented refactor for mask brush

Updated to use two separate vectors to try to make this a bit clearer, no real performance changes.

Sean Kim pushed to mask-brush-refactor at Sean-Kim/blender 2024-06-12 22:33:30 +02:00
e5635751f7 Add thread isolation
08d1691d2a Simplify mask calculation
e0973153e0 Remove unnecessary namespace
7e25cb783a Comment formatting
b6ef10da4d std::clamp
Compare 5 commits »
Sean Kim commented on pull request blender/blender#123152 2024-06-12 22:09:53 +02:00
Cleanup: Sculpt: Rename and move plane-based brush utilities

What do you think about naming this and the below function something like

Sean Kim commented on pull request blender/blender#123115 2024-06-12 21:07:39 +02:00
Sculpt: Initial data-oriented refactor for mask brush

Ah, it appears I copied this pattern from the draw_brush above, I'll remove it here.

Sean Kim deleted branch variable-docs from Sean-Kim/blender 2024-06-12 20:56:56 +02:00
Sean Kim merged pull request blender/blender#123143 2024-06-12 20:56:54 +02:00
Cleanup: Add docstring to StrokeCache bstrength