Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#123115 2024-06-12 16:57:15 +02:00
Sculpt: Initial data-oriented refactor for mask brush

This makes a lot more sense yeah, I was trying to figure out how to move the strength > 0.0f call out of the main loop

Sean Kim commented on pull request blender/blender#123101 2024-06-12 16:54:24 +02:00
Sculpt: Initial data oriented refactor for multires displacement eraser

Oh, interesting. Thanks for the background information here.

Sean Kim created pull request blender/blender#123115 2024-06-12 08:32:20 +02:00
Sculpt: Initial data-oriented refactor for mask brush
Sean Kim pushed to mask-brush-refactor at Sean-Kim/blender 2024-06-12 08:30:54 +02:00
ea567364f6 Sculpt: Initial data-oriented refactor for mask brush
Sean Kim created branch mask-brush-refactor in Sean-Kim/blender 2024-06-12 08:30:54 +02:00
Sean Kim commented on pull request blender/blender#122906 2024-06-12 06:48:10 +02:00
Sculpt: Initial data-oriented refactor for smooth brush

If we want to push this further down the line I think that's fine with me again. I'd generally argue that the helpfulness of this type of testing is more for making future changes easier, but it's…

Sean Kim created pull request blender/blender#123112 2024-06-12 06:30:57 +02:00
Cleanup: Add missing forward declaration
Sean Kim created branch stroke-cache-declaration in Sean-Kim/blender 2024-06-12 06:30:10 +02:00
Sean Kim pushed to stroke-cache-declaration at Sean-Kim/blender 2024-06-12 06:30:10 +02:00
702b54584d Cleanup: Add missing forward declaration
2665be7834 Merge branch 'blender-v4.2-release'
b37c4ae28c Merge branch 'blender-v4.2-release'
8112ee47d9 Merge branch 'blender-v4.2-release'
820fc124d4 Extensions: store repository data in a named tuple
Compare 10 commits »
Sean Kim commented on pull request blender/blender#123101 2024-06-12 05:52:57 +02:00
Sculpt: Initial data oriented refactor for multires displacement eraser

Minor comments, haven't had the chance to pull down and test this yet

Sean Kim commented on pull request blender/blender#123101 2024-06-12 05:52:56 +02:00
Sculpt: Initial data oriented refactor for multires displacement eraser

Is this call unnecessary? I don't see it in the refactored code

Sean Kim commented on pull request blender/blender#123101 2024-06-12 05:52:55 +02:00
Sculpt: Initial data oriented refactor for multires displacement eraser

Bringing this up here because I noticed it while doing changes in the mask brush and wanted to get your thoughts - for SCULPT_brush_strength_factor, it has separate arguments for vertex / face normals. Do you think it's important to maintain the existing mapping in these refactorings (i.e. Multires and Dyntopo assign to fno and Mesh assigns to vno) - based on the BKE_pbvh_vertex_iter_begin macro

Sean Kim deleted branch mesh-brush-common-forward from Sean-Kim/blender 2024-06-10 23:27:50 +02:00
Sean Kim pushed to main at blender/blender 2024-06-10 23:27:45 +02:00
b1763aa576 Cleanup: Add missing PBVH forward declaration
Sean Kim merged pull request blender/blender#123039 2024-06-10 23:27:44 +02:00
Cleanup: Add missing PBVH forward declaration
Sean Kim commented on pull request blender/blender#123039 2024-06-10 23:21:28 +02:00
Cleanup: Add missing PBVH forward declaration

Shouldn't we merge this also to blender-v4.2-release?

This file was only committed after the stabilizing branch was made - there's no changes for the release branch to merge.

Sean Kim created pull request blender/blender#123039 2024-06-10 23:09:54 +02:00
Cleanup: Add missing PBVH forward declaration
Sean Kim pushed to mesh-brush-common-forward at Sean-Kim/blender 2024-06-10 23:09:23 +02:00
2ad646a70f Cleanup: Add missing PBVH forward declaration
2e4be975fe Cleanup: Formatting in geometry nodes add menu
1b6910c61c UI: Remove Tooltip Zoom - Never Resize
d1455c4138 Geometry Nodes: Add STL Import Node
d573ee1e6c Sculpt: Use more specific update tags
Compare 10 commits »
Sean Kim created branch mesh-brush-common-forward in Sean-Kim/blender 2024-06-10 23:09:23 +02:00
Sean Kim commented on pull request blender/blender#122906 2024-06-10 20:26:27 +02:00
Sculpt: Initial data-oriented refactor for smooth brush

Ah that makes sense, I figured it was something like that. I didn't realize that the accumulate_counts_to_offsets call expected it to be size() + 1 and assumed that the OffsetIndicies