This makes a lot more sense yeah, I was trying to figure out how to move the strength > 0.0f call out of the main loop
Oh, interesting. Thanks for the background information here.
If we want to push this further down the line I think that's fine with me again. I'd generally argue that the helpfulness of this type of testing is more for making future changes easier, but it's…
Minor comments, haven't had the chance to pull down and test this yet
Is this call unnecessary? I don't see it in the refactored code
Bringing this up here because I noticed it while doing changes in the mask brush and wanted to get your thoughts - for SCULPT_brush_strength_factor, it has separate arguments for vertex / face normals. Do you think it's important to maintain the existing mapping in these refactorings (i.e. Multires and Dyntopo assign to fno and Mesh assigns to vno) - based on the BKE_pbvh_vertex_iter_begin macro
Shouldn't we merge this also to blender-v4.2-release?
This file was only committed after the stabilizing branch was made - there's no changes for the release branch to merge.
Ah that makes sense, I figured it was something like that. I didn't realize that the accumulate_counts_to_offsets call expected it to be size() + 1 and assumed that the OffsetIndicies…