Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim pushed to blender-v4.2-release at blender/blender 2024-06-06 22:11:43 +02:00
afa4523322 Fix #121008: Paint undo causes uncolored mesh
Sean Kim merged pull request blender/blender#122850 2024-06-06 22:11:42 +02:00
Fix #121008: Paint undo causes uncolored mesh
Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-06-06 22:05:16 +02:00
9b34d995df Merge branch 'main' of projects.blender.org:blender/blender into lasso-stabilize
427e8ab881 UI: Add tooltips for texture shader node inputs
5411ace289 Merge branch 'blender-v4.2-release'
fe4c28f2dc Fix: Benchmarks auto build not working with new lib directories
cdcefa43e3 Fix #119703: Incorrect conversion of identity quaternion to axis angle
Compare 414 commits »
Sean Kim pushed to fix-121008-opt-1 at Sean-Kim/blender 2024-06-06 21:42:33 +02:00
41ce768ac8 Prefer PBVH mesh values for mesh color attributes
982c78d65a Revert "Fix #121008: Paint undo causes uncolored mesh"
Compare 2 commits »
Sean Kim commented on pull request blender/blender#122850 2024-06-06 21:33:51 +02:00
Fix #121008: Paint undo causes uncolored mesh

Briefly discussed this offline, updating here for posterity:

I'm updating this PR to make a similar change inside pbvh_draw_args_init as the previously mentioned commit since this is…

Sean Kim commented on pull request blender/blender#122845 2024-06-06 21:09:19 +02:00
Fix #122786: Multiresolution > Apply Base produces garbled meshes

This should also be targeted against blender-v4.2-release, not main, you'll probably need a rebase for this if it wasn't already done

Sean Kim commented on pull request blender/blender#122850 2024-06-06 20:56:55 +02:00
Fix #121008: Paint undo causes uncolored mesh

An alternative solution here is to do the same thing that was done in a86658a58a - however, this PR seems to fix…

Sean Kim created pull request blender/blender#122850 2024-06-06 20:52:39 +02:00
Fix #121008: Paint undo causes uncolored mesh
Sean Kim pushed to fix-121008-opt-1 at Sean-Kim/blender 2024-06-06 20:49:25 +02:00
bea2226044 Fix #121008: Paint undo causes uncolored mesh
fe4c28f2dc Fix: Benchmarks auto build not working with new lib directories
cdcefa43e3 Fix #119703: Incorrect conversion of identity quaternion to axis angle
9f1f869e16 make.bat: Enable .py formatting with make format
a6cfc86469 Fix #86114: Multires Displacement Smear brush + Dyntopo Error
Compare 10 commits »
Sean Kim created branch fix-121008-opt-1 in Sean-Kim/blender 2024-06-06 20:49:25 +02:00
Sean Kim commented on issue blender/blender#121008 2024-06-06 19:52:24 +02:00
sculpt mode | paint/undo/color attribute

Thanks @lichtwerk - I'll have a fix for this shortly

Sean Kim created branch fix-121008 in Sean-Kim/blender 2024-06-06 19:27:29 +02:00
Sean Kim pushed to fix-121008 at Sean-Kim/blender 2024-06-06 19:27:29 +02:00
348fc68407 Fix #121008: Undo paint results in black mesh
aa81e2dd4a Fix #122455: Wireframe overlay can crash with loose geometry
b5a4786064 GPv3: Draw Tool: Stabilize Stroke setting
0ac65555b2 Cleanup: GPv3: Draw Tool: Shorten name in UI
57e92e9192 Fix: Overlay: Facing overlay is not transparent with zero alpha
Compare 10 commits »
Sean Kim commented on issue blender/blender#121008 2024-06-05 17:59:28 +02:00
sculpt mode | paint/undo/color attribute

see: blender/blender#121008 (comment)

@PratikPB2123 - I noticed it when I started looking into this, but I have issues actually bisecting around…

Sean Kim commented on issue blender/blender#121008 2024-06-05 01:57:23 +02:00
sculpt mode | paint/undo/color attribute

I suspect it's this commit: f15bca64f2

Sean Kim commented on pull request blender/blender#122746 2024-06-05 00:52:51 +02:00
Sculpt: Clarify and simplify PBVH bounds recalculation

Two minor comments inline.

Sean Kim commented on pull request blender/blender#122746 2024-06-05 00:52:50 +02:00
Sculpt: Clarify and simplify PBVH bounds recalculation

This method seems like a good candidate for a few unit tests.

Sean Kim commented on pull request blender/blender#122746 2024-06-05 00:52:49 +02:00
Sculpt: Clarify and simplify PBVH bounds recalculation

Maybe update_bounds_orig here or something like preserve_current_bounds? At first read reset_bounds_orig makes me think we're resetting the bounds value to its initial setting.

Sean Kim commented on issue blender/blender#121008 2024-06-05 00:43:14 +02:00
sculpt mode | paint/undo/color attribute

My previous update is just providing further context to anyone reading, I'm still working on figuring out what is causing this issue.

Sean Kim deleted branch adjust-trim-extrude-description from Sean-Kim/blender 2024-06-04 20:27:03 +02:00