Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-05-31 01:20:31 +02:00
f0e8e31c05 Remove WIP python code for accessing the active tool keymap
Sean Kim created pull request blender/blender#122519 2024-05-31 01:12:54 +02:00
WIP: Python: Allow access to operator properties via datapath
Sean Kim created branch acitve-tool-keymap in Sean-Kim/blender 2024-05-31 01:09:26 +02:00
Sean Kim pushed to acitve-tool-keymap at Sean-Kim/blender 2024-05-31 01:09:26 +02:00
897070f2a2 WIP: Python: Allow access to operator properties via datapath
Sean Kim commented on pull request blender/blender#122062 2024-05-30 07:23:44 +02:00
Sculpt: Add stroke stabilization to lasso tools

I can spin off a separate design task for the points you've listed here. I appreciate the feedback on the next steps for it. For this to be in a shippable state, do you think the only areas that…

Sean Kim commented on pull request blender/blender#122062 2024-05-30 05:39:18 +02:00
Sculpt: Add stroke stabilization to lasso tools

This is needed inside draw_lasso_smooth_stroke_indicator for the current mouse position, as we don't have a handle to the wmEvent in the wm_gesture_draw_* methods to get the current mouse…

Sean Kim commented on pull request blender/blender#122062 2024-05-30 05:34:33 +02:00
Sculpt: Add stroke stabilization to lasso tools

When I was doing some testing, this only seemed to occur specifically for the new use_smooth_stroke property on the operator. I couldn't replicate this for a handful of WM_OT_context_toggle

Sean Kim commented on pull request blender/blender#122062 2024-05-30 02:17:16 +02:00
Sculpt: Add stroke stabilization to lasso tools

@blender-bot package

Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-05-30 02:16:27 +02:00
9d1271965f Prevent NoneType error
aafa882a72 Remove missed keymap entry
fd56ecca87 Remove commented code, change naming
e54210ec3a Finish implementation
1d9051acf0 WIP: Sculpt: Add stroke stabilization to lasso tools
Compare 64 commits »
Sean Kim commented on pull request blender/blender#122062 2024-05-30 01:48:52 +02:00
Sculpt: Add stroke stabilization to lasso tools

Only just noticed that the build failed, Looking into the test failures now...

Sean Kim suggested changes for blender/blender#122437 2024-05-29 23:50:22 +02:00
UI: Reorganize mesh sculpt mode menus

Overall I agree with the changes and I think this looks much better organized as a whole, though I can't really provide detailed input from the user side. Requesting changes specifically for the line in space_view3d.py

Sean Kim commented on pull request blender/blender#122437 2024-05-29 23:50:21 +02:00
UI: Reorganize mesh sculpt mode menus

This name is slightly odd to me. I see that showhide has a precedence elsewhere in this file, but I think this is probably fine as VIEW3D_MT_sculpt_trim

Sean Kim commented on pull request blender/blender#122437 2024-05-29 23:50:20 +02:00
UI: Reorganize mesh sculpt mode menus

This appears to be mistakenly added?

Sean Kim commented on pull request blender/blender#122437 2024-05-29 23:30:55 +02:00
UI: Reorganize mesh sculpt mode menus

2, Line Mask is missing from Mask menus gesture operators. Is that intentional or forgotten?

Found the [commit](https://projects.blender.org/blender/blender/commit/8c81b3fb8b9c857626c037fe0c95

Sean Kim commented on pull request blender/blender#122419 2024-05-29 23:11:46 +02:00
Cleanup: Remove accidentially added constexpr qualifier

Why remove this? It doesn't hurt AFAIK

It doesn't hurt, but it doesn't really provide any benefit either to how we use the value in the code at the moment, so I view it as kind of misleading,…

Sean Kim created pull request blender/blender#122419 2024-05-29 08:38:50 +02:00
Cleanup: Remove accidentially added constexpr qualifier
Sean Kim created branch remove-constexpr in Sean-Kim/blender 2024-05-29 08:34:17 +02:00
Sean Kim pushed to remove-constexpr at Sean-Kim/blender 2024-05-29 08:34:17 +02:00
19ecaf61b7 Cleanup: Remove accidentially added constexpr qualifier
Sean Kim commented on pull request blender/blender#122062 2024-05-29 08:28:23 +02:00
Sculpt: Add stroke stabilization to lasso tools

@blender-bot package