Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim merged pull request blender/blender#122026 2024-05-21 18:21:06 +02:00
BLI: Add BitGroupVector copy constructor
Sean Kim commented on pull request blender/blender#122026 2024-05-21 18:20:03 +02:00
BLI: Add BitGroupVector copy constructor

Spoke with Hans offline, since this is a simple change, I'm going ahead with the merge now.

Sean Kim commented on pull request blender/blender#122026 2024-05-21 18:10:29 +02:00
BLI: Add BitGroupVector copy constructor

Oops, missed that constructor - went straight for trying the BoundedBitSpan with other.data_() and couldn't get that to work.

Sean Kim pushed to bit-group-vector-copy at Sean-Kim/blender 2024-05-21 18:09:52 +02:00
5185fb43b0 Use BitVector copy constructor
Sean Kim commented on pull request blender/blender#122026 2024-05-21 04:55:30 +02:00
BLI: Add BitGroupVector copy constructor
Sean Kim commented on pull request blender/blender#120282 2024-05-21 03:49:27 +02:00
Sculpt: Add increase / decrease visibility operator

PR: #122026

Sean Kim created pull request blender/blender#122026 2024-05-21 03:48:39 +02:00
BLI: Add BitGroupVector copy constructor
Sean Kim pushed to bit-group-vector-copy at Sean-Kim/blender 2024-05-21 03:47:46 +02:00
628af000ca BLI: Add BitGroupVector copy constructor
Sean Kim created branch bit-group-vector-copy in Sean-Kim/blender 2024-05-21 03:47:46 +02:00
Sean Kim commented on pull request blender/blender#120282 2024-05-21 00:57:23 +02:00
Sculpt: Add increase / decrease visibility operator

Good ideas overall. I'll try a few approaches and see what gets some performance gains.

Sean Kim commented on pull request blender/blender#120282 2024-05-21 00:56:25 +02:00
Sculpt: Add increase / decrease visibility operator

I'll pull this out into a separate PR.

Sean Kim commented on pull request blender/blender#120282 2024-05-21 00:55:55 +02:00
Sculpt: Add increase / decrease visibility operator

Yeah, I think that's probably fine here - I separated it out into a new enum because I was considering if this would be expanded like other Filter operators, but I think that change can happen…

Sean Kim deleted branch face-set-cleanup from Sean-Kim/blender 2024-05-18 22:18:57 +02:00
Sean Kim pushed to main at blender/blender 2024-05-18 22:18:54 +02:00
99505b58e9 Cleanup: Remove unncessary prefixes in sculpt_face_set.cc
Sean Kim merged pull request blender/blender#121895 2024-05-18 22:18:54 +02:00
Cleanup: Remove unncessary prefixes in sculpt_face_set.cc
Sean Kim pushed to main at blender/blender-developer-docs 2024-05-18 07:28:47 +02:00
dc13d1e529 Update docs/release_notes/4.2/sculpt.md
Sean Kim commented on issue blender/blender#121931 2024-05-18 07:07:56 +02:00
Sculpting -> Box-Trim on "Hi"-Poly/Voxelcount extremely slow / crashing Blender

This is unfortunately a known issue with blender's trim tools - see #84229 for more details. In the upcoming 4.2 release, a different boolean solver option is provided which is a fair bit faster…

Sean Kim commented on pull request blender/blender#121929 2024-05-18 01:01:39 +02:00
Fix #95419: Sculpt: Invert visible hides all faces with Multires modifier

Just a nit, PR title format for this would probably be better as something like

Fix #95419: Avoid changing vert index on multires visibility
Sean Kim pushed to face-set-cleanup at Sean-Kim/blender 2024-05-18 00:40:34 +02:00
7894ae47fb PR feedback