Just an update here from the module meeting - planning on going with the global header option right now to make it the most consistent with other modes so that it's more consistent with other modes.
Uploading the two different options for where the header could be (mentioned in the UI module chat)
Actually, we need the index_range()
here because this is following the same scatter
/ gather
pattern that's used in the other callbacks like calc_hide
- node_faces
and hide_face
are…
Whoops, yeah that's definitely a better option. Will do.
Closing this PR in favor of the newer one linked above.
Adding the number of samples makes sense, but I don't think the max is very meaningful honestly. That's so dependent on whether the operating system decided to schedule some other task at the…
Hi. Is this already in master?
Amazing work. Thank you.
Not yet, this is still pending code review.