Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#120845 2024-04-30 16:47:58 +02:00
Sculpt: Add Line Trim tool

I am not getting expected behaviour from this build. Using the line trim tool in sculpt mode gives me a cut line on parts of the mesh. Check the attached video

Very strange behavior... I'll…

Sean Kim commented on pull request blender/blender#120282 2024-04-29 20:46:20 +02:00
Sculpt: Add increase / decrease visibility operator

Regarding the multires functionality, I thought I had it working in the build before requesting review initially, but a change I did in the meantime must have broken it. I'll take a look at it…

Sean Kim opened issue blender/blender#121152 2024-04-27 01:19:04 +02:00
Create thread isolated version of threading::parallel_for
Sean Kim commented on issue blender/blender#121107 2024-04-26 10:41:32 +02:00
Regression: Box Hide occasionally causes artifacts

Adding this

    for (PBVHNode *node : nodes.slice(range)) {
      std::stringstream msg;
      msg << std::this_thread::get_id() << "\t" << node << "\t" << &new_hide << std::endl;
     …
Sean Kim commented on issue blender/blender#121107 2024-04-26 09:29:00 +02:00
Regression: Box Hide occasionally causes artifacts

Adding this assert into paint_hide.cc in vert_hide_update shows the problem I think.

  threading::EnumerableThreadSpecific<Vector<bool>> all_new_hide;
  threading::parallel_for(nodes.i…
Sean Kim commented on issue blender/blender#121107 2024-04-26 08:44:29 +02:00
Regression: Box Hide occasionally causes artifacts

Running with a debugger gets this particular block as triggering the assert:

  vert_hide_update(*object, nodes, [&](const Span<int> verts, MutableSpan<bool> hide) {
    for (const int i :…
Sean Kim opened issue blender/blender#121107 2024-04-26 07:47:23 +02:00
Box Hide occasionally causes artifacts
Sean Kim deleted branch fix-indexed-data_equal from Sean-Kim/blender 2024-04-25 02:32:18 +02:00
Sean Kim created pull request blender/blender#121056 2024-04-25 01:37:30 +02:00
Refactor: Invert return value of array_utils::indexed_data_equal
Sean Kim pushed to fix-indexed-data_equal at Sean-Kim/blender 2024-04-25 01:35:39 +02:00
ae43a355c2 Refactor: Invert return value of array_utils::indexed_data_equal
cff532e134 VSE: Implement Snapping to Markers
5644a0c621 Fix: EEVEE-Next: Sphere probe disregard the custom parallax checkbox
8d740b6ea3 Cleanup: DRW: Remove unused legacy function
2babe2d678 Fix: EEVEE-Next: Volume objects gets incorrectly culled
Compare 10 commits »
Sean Kim created branch fix-indexed-data_equal in Sean-Kim/blender 2024-04-25 01:35:38 +02:00
Sean Kim deleted branch bke-mesh-comment from Sean-Kim/blender 2024-04-24 23:51:04 +02:00
Sean Kim created pull request blender/blender#121000 2024-04-24 02:31:39 +02:00
Cleanup: Fix function comments in BKE_mesh.hh
Sean Kim pushed to bke-mesh-comment at Sean-Kim/blender 2024-04-24 02:30:38 +02:00
48c754954c Cleanup: Fix function comments in BKE_mesh.hh
Sean Kim pushed to bke-mesh-comment at Sean-Kim/blender 2024-04-24 02:29:36 +02:00
cff532e134 VSE: Implement Snapping to Markers
5644a0c621 Fix: EEVEE-Next: Sphere probe disregard the custom parallax checkbox
8d740b6ea3 Cleanup: DRW: Remove unused legacy function
2babe2d678 Fix: EEVEE-Next: Volume objects gets incorrectly culled
a652543568 Tests: Compositor: add bilinear and bicubic tests
Compare 10 commits »
Sean Kim created branch bke-mesh-comment in Sean-Kim/blender 2024-04-24 02:29:36 +02:00
Sean Kim commented on pull request blender/blender#120798 2024-04-24 02:28:20 +02:00
Fix #120761: Tag all PBVH nodes for needing a visibility update when using hide tools

I agree with not requiring visibility updates outside of vert_hide_update. But I don't think option 2 requires that. vert_hide_update would just contain a second loop over nodes and would…

Sean Kim deleted branch sculpt-project-cleanup from Sean-Kim/blender 2024-04-24 02:02:28 +02:00
Sean Kim created pull request blender/blender-developer-docs#51 2024-04-24 01:56:44 +02:00
Update docs/handbook/development_environments/vscode.md
Sean Kim pushed to vscode-fixes at Sean-Kim/blender-developer-docs 2024-04-24 01:54:57 +02:00
2efce05970 Update docs/handbook/development_environments/vscode.md
b5b5bad4a2 4.2: Mention new python function for F-Curves bake
Compare 2 commits »