Sean Kim Sean-Kim

2 Followers · 0 Following

• Joined on 2023-12-14

Overview Repositories

5

Projects Public Activity Starred Repositories

1

Sean Kim approved blender/blender#123671 2024-06-25 00:03:23 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

Mainly style nitpicks here; did a comparison with the corresponding functions and didn't spot any issues.

Sean Kim commented on pull request blender/blender#123671 2024-06-25 00:03:22 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

One area that I think the code in sculpt_brush_test_clipping is better than this refactored section is the collection of related attributes inside SculptBrushTest - maybe it's worth having a struct here specifically for mirror_symmetry_pass, radial_symmetry_pass, and symm_rot_mat_inv? I don't feel as strongly about rv3d and v3d being included.

Sean Kim commented on pull request blender/blender#123671 2024-06-25 00:03:21 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

Nit:

Sean Kim commented on pull request blender/blender#123671 2024-06-25 00:03:20 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

Nit:

Sean Kim commented on pull request blender/blender#123671 2024-06-25 00:03:19 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

Nit:

Sean Kim commented on pull request blender/blender#123671 2024-06-25 00:03:18 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

Nit: Same organizational nit as above.

Sean Kim commented on pull request blender/blender#123671 2024-06-25 00:03:17 +02:00

Sculpt: Refactor distance falloff, clipping, and brush strength

Nit: I'd put this after the other BKE_brush_curve_strength declaration so that we don't separate the overloads, probably worth adding a small docstring here too.

Sean Kim pushed to main at blender/blender 2024-06-24 22:59:17 +02:00

d863785775 Merge branch 'blender-v4.2-release'

2cc6de8f7e Fix #123574: Automask area normal causes garbled meshes

Compare 2 commits »

Sean Kim deleted branch fix-123574 from Sean-Kim/blender 2024-06-24 22:57:27 +02:00

Sean Kim closed issue blender/blender#123574 2024-06-24 22:57:24 +02:00

Regression: Mesh Filter with Area Automasking causes odd artifacts

Sean Kim pushed to blender-v4.2-release at blender/blender 2024-06-24 22:57:20 +02:00

2cc6de8f7e Fix #123574: Automask area normal causes garbled meshes

Sean Kim merged pull request blender/blender#123697 2024-06-24 22:57:20 +02:00

Fix #123574: Automask area normal causes garbled meshes

Sean Kim commented on pull request blender/blender#123697 2024-06-24 22:55:03 +02:00

Fix #123574: Automask area normal causes garbled meshes

Ugh, I always miss that option - fixing

Sean Kim created pull request blender/blender#123697 2024-06-24 22:45:49 +02:00

Fix #123574: Automask area normal causes garbled meshes

Sean Kim pushed to fix-123574 at Sean-Kim/blender 2024-06-24 22:45:12 +02:00

2777ea383f Fix #123574: Automask area normal causes garbled meshes

4bde68cdd6 Cycles: Compress GPU kernels to reduce file size

cf73897690 Extensions: add HTML generation to the "server-generate" command

fc3e0507cc Extensions: development functionality to mark all & clear marks

1ba06956e7 Extensions: support platform & version from URL parameters

Compare 6 commits »

Sean Kim created branch fix-123574 in Sean-Kim/blender 2024-06-24 22:45:12 +02:00

Sean Kim pushed to main at blender/blender 2024-06-24 18:34:11 +02:00

e140f263d0 Fix #122856: Sculpt trim and filter tools do not show brush cursor

Sean Kim deleted branch sculpt-trim-cursor from Sean-Kim/blender 2024-06-24 18:34:10 +02:00

Sean Kim closed issue blender/blender#122856 2024-06-24 18:34:09 +02:00

Regression: Sculpt mode tools not using the sculpt cursor

Sean Kim merged pull request blender/blender#123570 2024-06-24 18:34:07 +02:00

Fix #122856: Sculpt trim and filter tools do not show brush cursor