Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim created branch geom-node-sort in Sean-Kim/blender 2024-03-12 15:39:47 +01:00
Sean Kim pushed to geom-node-sort at Sean-Kim/blender 2024-03-12 15:39:47 +01:00
53daefa00f Fix: Avoid potential mac std::sort comparator issue
aa3ffca8dc Fix #119247: Curves: Extra point in evaluated spline of Curves geometry
986577f4ce Merge branch 'blender-v4.1-release'
825e662229 Fix #119021: Crash when adding GP object
04de6472b5 Cleanup: Use C++ Array instead of manual allocation
Compare 10 commits »
Sean Kim opened issue blender/blender#119353 2024-03-12 00:44:16 +01:00
UX: Polyline Gesture
Sean Kim commented on pull request blender/blender#119140 2024-03-10 01:22:50 +01:00
Sculpt: Add Lasso Hide tool

Addressed feedback

Sean Kim pushed to 80390-lasso-gesture-hide at Sean-Kim/blender 2024-03-10 01:17:32 +01:00
342afa9ed6 PR style feedback
a8b4242cb5 Enable spacebar drag and single click show all
6a2e30f3ec Adjust to recent merged changes
87b44c4f8b Merge branch 'main' of projects.blender.org:blender/blender into 80390-lasso-gesture-hide-v2
5b522359ee Cleanup: Centralize MSVC conformance related cmake items
Compare 119 commits »
Sean Kim deleted branch 80390-lasso-gesture-hide-v2 from Sean-Kim/blender 2024-03-10 01:08:44 +01:00
Sean Kim created branch 80390-lasso-gesture-hide-v2 in Sean-Kim/blender 2024-03-10 01:07:36 +01:00
Sean Kim pushed to 80390-lasso-gesture-hide-v2 at Sean-Kim/blender 2024-03-10 01:07:36 +01:00
342afa9ed6 PR style feedback
a8b4242cb5 Enable spacebar drag and single click show all
6a2e30f3ec Adjust to recent merged changes
87b44c4f8b Merge branch 'main' of projects.blender.org:blender/blender into 80390-lasso-gesture-hide-v2
5b522359ee Cleanup: Centralize MSVC conformance related cmake items
Compare 10 commits »
Sean Kim commented on pull request blender/blender#119140 2024-03-09 23:50:28 +01:00
Sculpt: Add Lasso Hide tool

Marked as WIP for now until I address the two usecases pointed out above.

Sean Kim commented on pull request blender/blender#119140 2024-03-09 23:11:32 +01:00
Sculpt: Add Lasso Hide tool

@DanielBystedt - Thanks for the performance testing!

@TheRedWaxPolice - Thanks for the feedback and testing, I'll look into both of those this coming week.

Sean Kim commented on pull request blender/blender#119233 2024-03-09 02:39:16 +01:00
Fix: Memory leak from sculpt paint lasso

Looks good to me.

@deadpin - If you want I can make a PR for the equivalent change in main

Sean Kim commented on pull request blender/blender#119140 2024-03-08 18:13:25 +01:00
Sculpt: Add Lasso Hide tool

I get the concern - but this particular code path would be handling the opposite use-case if lassoing a small portion of a large mesh - most pbvh nodes would pass the `BKE_pbvh_node_frustum_exclude…

Sean Kim created branch geom-node-mac-fix in Sean-Kim/blender 2024-03-08 00:16:44 +01:00
Sean Kim pushed to geom-node-mac-fix at Sean-Kim/blender 2024-03-08 00:16:44 +01:00
341130be96 Fix: Avoid potential mac std::sort comparator issue
e0c6db81ea Tests: Blacklist microfacet hair test on GPU, due to different curve shape
4d958ca19a Fix: View in Graph Editor not working when object is unselected
Compare 3 commits »
Sean Kim created pull request blender/blender#119189 2024-03-07 23:36:08 +01:00
Fix #119014: Crash on keymap editing for Mac
Sean Kim pushed to 119104-mac-crash at Sean-Kim/blender 2024-03-07 23:29:39 +01:00
2e38e7d1df Fix #119014: Crash on keymap editing for Mac
Sean Kim created branch 119104-mac-crash in Sean-Kim/blender 2024-03-07 23:28:45 +01:00
Sean Kim pushed to 119104-mac-crash at Sean-Kim/blender 2024-03-07 23:28:45 +01:00
e08a3bf9f6 Fix: TBD
4e196f916c Cleanup: Remove unnecessary AssetListStorage class
ab3b8df693 Fix #116249: Compositor: Gizmos ignore backdrop transformations
d99fffc460 GPv3: Legacy Conversion: Animation: Optimize fcurves handling.
90ef46baa1 Anim: DNA for Animation data-block
Compare 10 commits »
Sean Kim commented on issue blender/blender#119014 2024-03-07 19:19:46 +01:00
Crash while editing keymap entry (MacOS only)

blender/blender#93285 had a similar issue - I think the correct move here is to apply the change to use < over <= and then clean up any other usage of this…

Sean Kim commented on issue blender/blender#119014 2024-03-07 19:04:25 +01:00
Crash while editing keymap entry (MacOS only)

No exception is thrown, if to change comparator to:

return a->name.compare(b->name);

I suspect that some values in a list with condition `BLI_strcasecmp_natural(a->name.c_str…