Not for the PR but thanks for the note. Should there be a
BLI_math_snappingto store the math functions?
In general yeah I think something like BLI_math_snapping would be good for it,…
Seems generally reasonable to me; I think this consolidates the code well. I didn't do a lot of manual testing here, but I verified that we didn't regress and reintroduce the bug mentioned in #126199
Just as a note here - while this won't crash anymore, this has likely never behaved in the way one would expect with an eyedropper; it is only able to sample from the currently active sculpt object
Closing for now then; feel free to reopen or create a new issue if you can reproduce this again.
This seems reasonable - only thought I had was if we want to use the "last active vertex" that was introduced for the expand operator, but I'm on the fence as to whether that's as important here. I think in this case it's valid to just cancel the operation
Wasn't entirely certain who to tag for review for this, just took a stab in the dark since Brecht is still on sabbatical and he worked on the code being modified here