Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#122062 2024-05-30 05:34:33 +02:00
Sculpt: Add stroke stabilization to lasso tools

When I was doing some testing, this only seemed to occur specifically for the new use_smooth_stroke property on the operator. I couldn't replicate this for a handful of WM_OT_context_toggle

Sean Kim commented on pull request blender/blender#122062 2024-05-30 02:17:16 +02:00
Sculpt: Add stroke stabilization to lasso tools

@blender-bot package

Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-05-30 02:16:27 +02:00
9d1271965f Prevent NoneType error
aafa882a72 Remove missed keymap entry
fd56ecca87 Remove commented code, change naming
e54210ec3a Finish implementation
1d9051acf0 WIP: Sculpt: Add stroke stabilization to lasso tools
Compare 64 commits »
Sean Kim commented on pull request blender/blender#122062 2024-05-30 01:48:52 +02:00
Sculpt: Add stroke stabilization to lasso tools

Only just noticed that the build failed, Looking into the test failures now...

Sean Kim suggested changes for blender/blender#122437 2024-05-29 23:50:22 +02:00
UI: Reorganize mesh sculpt mode menus

Overall I agree with the changes and I think this looks much better organized as a whole, though I can't really provide detailed input from the user side. Requesting changes specifically for the line in space_view3d.py

Sean Kim commented on pull request blender/blender#122437 2024-05-29 23:50:21 +02:00
UI: Reorganize mesh sculpt mode menus

This name is slightly odd to me. I see that showhide has a precedence elsewhere in this file, but I think this is probably fine as VIEW3D_MT_sculpt_trim

Sean Kim commented on pull request blender/blender#122437 2024-05-29 23:50:20 +02:00
UI: Reorganize mesh sculpt mode menus

This appears to be mistakenly added?

Sean Kim commented on pull request blender/blender#122437 2024-05-29 23:30:55 +02:00
UI: Reorganize mesh sculpt mode menus

2, Line Mask is missing from Mask menus gesture operators. Is that intentional or forgotten?

Found the [commit](https://projects.blender.org/blender/blender/commit/8c81b3fb8b9c857626c037fe0c95

Sean Kim commented on pull request blender/blender#122419 2024-05-29 23:11:46 +02:00
Cleanup: Remove accidentially added constexpr qualifier

Why remove this? It doesn't hurt AFAIK

It doesn't hurt, but it doesn't really provide any benefit either to how we use the value in the code at the moment, so I view it as kind of misleading,…

Sean Kim created pull request blender/blender#122419 2024-05-29 08:38:50 +02:00
Cleanup: Remove accidentially added constexpr qualifier
Sean Kim created branch remove-constexpr in Sean-Kim/blender 2024-05-29 08:34:17 +02:00
Sean Kim pushed to remove-constexpr at Sean-Kim/blender 2024-05-29 08:34:17 +02:00
19ecaf61b7 Cleanup: Remove accidentially added constexpr qualifier
Sean Kim commented on pull request blender/blender#122062 2024-05-29 08:28:23 +02:00
Sculpt: Add stroke stabilization to lasso tools

@blender-bot package

Sean Kim commented on pull request blender/blender#122062 2024-05-29 08:27:38 +02:00
Sculpt: Add stroke stabilization to lasso tools

I'm planning on extracting the bpy_types.py and wm.py changes to a separate PR / commit, since it's more core functionality and shouldn't be bundled with this, but I think the context of the…

Sean Kim commented on pull request blender/blender#122062 2024-05-29 08:25:19 +02:00
Sculpt: Add stroke stabilization to lasso tools

I don't know if there's a more appropriate way of achieving what this line does - without this, after Shift-S is pressed, the value in the header does not update until the cursor moves over the toolbar or outside of Blender's window.

Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-05-29 08:18:45 +02:00
7ca99c0147 Remove commented code, change naming
Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-05-29 08:10:32 +02:00
97c28a7fee Finish implementation
8149a59a03 Merge branch 'main' of projects.blender.org:blender/blender into lasso-stabilize
5bab443c63 Fix: EEVEE-Next: Fix broken Translucent Shadow bias
14f9ae90c2 EEVEE: fixing vector displacement
9faed28dcd Fix #122401: Missing animation rendering scene with "Render Single Layer"
Compare 309 commits »
Sean Kim pushed to main at blender/blender-developer-docs 2024-05-28 18:55:10 +02:00
89e611bffe Update docs/release_notes/4.2/sculpt.md
Sean Kim deleted branch polyline-gestures from Sean-Kim/blender 2024-05-28 18:34:03 +02:00