BLI_assert(indices.size() == compressed.size())
compressed seems a bit misleading here, especially given future plans to attempt to apply compression in general to the undo steps. That being said I don't have a good recommendation here... maybe flattened?
Manual testing done:
- Sculpting multiple strokes and undos with:
- Only base mesh
- Base Mesh + Shape Key
- Base Mesh + Shape Key + Subdiv Modifier
- On Basis / Relative Shape…
Aside from the inline code comment, this behaves as expected in mesh painting modes.
I don't understand why we pass nullptr here, it seems like this would cause a crash eventually from a null dereference in BKE_paint_use_unified_color
Some high-level feedback that was mentioned in the recent module meeting:
- Overall we like the idea and think this has good potential for both general artistic texture painting and potentially…
I'm not entirely certain what the behavior here should be. It seems a bit odd to me to be able to change the active tool from within the right-side tool menu. Perhaps this should automatically…
I'm going to close this issue since it no longer seems to be present. I do not get the assert mentioned in a current build of main, and we also provide a warning on the decimate modifier that it…