Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#128625 2024-10-07 18:15:18 +02:00
Fix #128601: Redoing move operation crash in sculpt mode

I think changing the order here is fine as a fix for this particular issue, but we may be squashing bugs similar to this for 4.3 unfortunately; ideally I think we would do something like bke::object::pbvh_ensure instead of bke::object::pbvh_get inside undo::push_begin_ex so that we're not dependent on external ordering, but unfortunately that requires a depsgraph object, which would mean changing the signature of push_begin_ex and push_begin to take it.

Sean Kim commented on pull request blender/blender#128632 2024-10-07 17:49:25 +02:00
Fix #128595: Mesh Filter Erase Displacement crashes without multires

Instead of checking for the subdiv_ccg, looking at the PBVH type is better.

Sean Kim commented on pull request blender/blender#128632 2024-10-07 17:49:24 +02:00
Fix #128595: Mesh Filter Erase Displacement crashes without multires

This comment is unnecessary, I'd remove it.

Sean Kim commented on issue blender/blender#93511 2024-10-03 06:10:52 +02:00
Unable to undo subdivision with Multiresolution modifier

Writing my current thoughts here: seems like the most straightforward way to solve this with geometry_push is to extend the NodeGeometry struct with two more CustomData layers for MDisps and…

Sean Kim commented on issue blender/blender#76374 2024-10-03 03:03:02 +02:00
Multires: Artefacts from lower subdiv level changes

There's a fix up for testing in the related PR

Sean Kim created pull request blender/blender#128515 2024-10-03 02:39:20 +02:00
Fix #76374: Multires artifacts when sculping on lower level
Sean Kim pushed to multires-details at Sean-Kim/blender 2024-10-03 02:38:39 +02:00
f9b94bf167 Fix #76374: Multires artifacts when sculping on lower level
Sean Kim created branch multires-details in Sean-Kim/blender 2024-10-03 02:34:16 +02:00
Sean Kim pushed to multires-details at Sean-Kim/blender 2024-10-03 02:34:16 +02:00
e30f6d35f0 Fix #76374: Multires artifacts when sculping on lower level
e55d54f46d Merge branch 'blender-v4.3-release'
d2a802d3c6 VSE: Remove timeline box select
574d02af4c Merge branch 'blender-v4.3-release'
177e2ac837 Grease Pencil: Tool settings layout adjustments
Compare 10 commits »
Sean Kim deleted branch group-mode-specific-undo from Sean-Kim/blender 2024-10-03 00:55:12 +02:00
Sean Kim merged pull request blender/blender#128512 2024-10-03 00:55:08 +02:00
Refactor: Group mode-specific Sculpt undo `StepData` into structs
Sean Kim pushed to main at blender/blender 2024-10-03 00:55:07 +02:00
20accbe4cf Refactor: Group mode-specific Sculpt undo StepData into structs
Sean Kim pushed to group-mode-specific-undo at Sean-Kim/blender 2024-10-03 00:03:37 +02:00
72e20e63af Refactor: Group mode-specific Sculpt undo StepData into structs
afd51876b0 Cleanup: Various non-functional changes for sculpt_undo.cc
Compare 2 commits »
Sean Kim created pull request blender/blender#128512 2024-10-03 00:02:16 +02:00
Refactor: Group mode-specific Sculpt undo StepData into structs
Sean Kim created branch group-mode-specific-undo in Sean-Kim/blender 2024-10-02 23:59:24 +02:00
Sean Kim pushed to group-mode-specific-undo at Sean-Kim/blender 2024-10-02 23:59:24 +02:00
fa2fb7167f Refactor: Group mode-specific Sculpt undo StepData into structs
8477a273dd Merge branch 'blender-v4.3-release'
4cefac0da3 Fix: Remove incorrect sculpt assert
65d56e6ae4 Merge branch 'blender-v4.3-release'
4a679470b6 Fix: USD: collection creation during import assigned extra fake user
Compare 10 commits »
Sean Kim deleted branch cleanup-sculpt-undo-cc from Sean-Kim/blender 2024-10-02 23:36:41 +02:00