Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#128260 2024-09-29 22:07:12 +02:00
Fix #128257: Crash when using Set Vertex Colors with no brush

Would you like me to poll then and revert my current changes? Or just make the requested changes?

I think adding the poll and reverting the change otherwise makes the most sense here

Sean Kim commented on issue blender/blender#128285 2024-09-29 22:02:58 +02:00
"Enhance Details" while smoothing in sculpt mode crashes Blender.

Are you using the brush with a tablet by any chance?

Sean Kim suggested changes for blender/blender#128260 2024-09-29 21:25:56 +02:00
Fix #128257: Crash when using Set Vertex Colors with no brush

I can't verify that this actually fixes the problem with this applied to current main, however, the fix seems reasonable in general, even if I don't know how you would get into a state in Vertex Paint where there's no brush selected.

Sean Kim commented on pull request blender/blender#128260 2024-09-29 21:25:55 +02:00
Fix #128257: Crash when using Set Vertex Colors with no brush

Instead of having this return bool and write into r_paintcol, I'd suggest making this return std::optional<ColorPaint4f>

Sean Kim deleted branch fix-clay-strips from Sean-Kim/blender 2024-09-29 21:08:22 +02:00
Sean Kim pushed to main at blender/blender 2024-09-29 21:08:21 +02:00
60acd02cf9 Fix: Sculpt: Clay strips brush ignores hardness
Sean Kim merged pull request blender/blender#128332 2024-09-29 21:08:20 +02:00
Fix: Sculpt: Clay strips brush ignores hardness
Sean Kim commented on pull request blender/blender#128332 2024-09-29 20:37:07 +02:00
Fix: Sculpt: Clay strips brush ignores hardness

@blender-bot build

Sean Kim created pull request blender/blender#128332 2024-09-29 20:36:43 +02:00
Fix: Sculpt: Clay strips brush ignores hardness
Sean Kim pushed to fix-clay-strips at Sean-Kim/blender 2024-09-29 20:35:35 +02:00
6ec31338aa Fix: Sculpt: Clay strips brush ignores hardness
4bc146f00a Refactor: Sculpt: Access mesh attributes once per brush step
012b0ec528 Fix #128262: Fix alignment in Grease Pencil layer tree view
774bf48925 Fix: Build error without OpenVDB
9c8c786a05 Fix error in studiolight preview
Compare 10 commits »
Sean Kim created branch fix-clay-strips in Sean-Kim/blender 2024-09-29 20:35:35 +02:00
Sean Kim deleted branch access-attributes-early from Sean-Kim/blender 2024-09-29 20:29:04 +02:00
Sean Kim pushed to main at blender/blender 2024-09-29 20:28:59 +02:00
4bc146f00a Refactor: Sculpt: Access mesh attributes once per brush step
Sean Kim merged pull request blender/blender#128286 2024-09-29 20:28:58 +02:00
Refactor: Sculpt: Access mesh attributes once per brush step
Sean Kim commented on pull request blender/blender#128286 2024-09-28 01:27:58 +02:00
Refactor: Sculpt: Access mesh attributes once per brush step

@blender-bot build

Sean Kim created pull request blender/blender#128286 2024-09-28 01:27:27 +02:00
Refactor: Sculpt: Access mesh attributes once per brush step
Sean Kim pushed to access-attributes-early at Sean-Kim/blender 2024-09-28 01:23:32 +02:00
aec0b348b0 Refactor: Sculpt: Access mesh attributes once per brush step
Sean Kim pushed to access-attributes-early at Sean-Kim/blender 2024-09-28 01:13:54 +02:00
c5c85b9665 Initial progress
6d83f9a6b3 Cleanup: Sculpt: Extract common factor calculation methods
6c62fe7ac8 Fix: Hydra memory leak when generated images are saved
04c5044e61 Fix: Hydra "Object" texture coordinates incorrectly set to "World"
a9fa3657a6 Fix (unreported) link/append code adding full ID names in some cases.
Compare 10 commits »
Sean Kim created branch access-attributes-early in Sean-Kim/blender 2024-09-28 01:13:53 +02:00
Sean Kim created pull request blender/blender-manual#104938 2024-09-27 20:48:51 +02:00
Sculpt: Add Mask from Boundary operators