Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#127959 2024-09-24 20:56:56 +02:00
Fix: Avoid accessing face set with invalid index

@blender-bot build

Sean Kim pushed to fix-active-face-set at Sean-Kim/blender 2024-09-24 20:52:19 +02:00
7ae15c4dd2 use nullopt
Sean Kim commented on pull request blender/blender#127959 2024-09-24 19:45:52 +02:00
Fix: Avoid accessing face set with invalid index

@blender-bot build

Sean Kim pushed to fix-active-face-set at Sean-Kim/blender 2024-09-24 19:42:17 +02:00
348d809f1b Use optional instead of -1
Sean Kim deleted branch create-boundary-mask from Sean-Kim/blender 2024-09-24 18:02:51 +02:00
Sean Kim merged pull request blender/blender#127787 2024-09-24 18:02:49 +02:00
Sculpt: Add Mask from Boundary Operator
Sean Kim pushed to main at blender/blender 2024-09-24 18:02:48 +02:00
591f4c0e59 Sculpt: Add Mask from Boundary Operator
Sean Kim commented on pull request blender/blender#127787 2024-09-24 16:10:08 +02:00
Sculpt: Add Mask from Boundary Operator

@ThinkingPolygons No worries - I added a comparison image to the first post too just for clarity

Sean Kim commented on pull request blender/blender#127787 2024-09-24 15:36:14 +02:00
Sculpt: Add Mask from Boundary Operator

@ThinkingPolygons Consistency with the Mask from Cavity operator is the main reason, which exposes the operator in the automasking panel and in the Mask menu, though in this case the Mask from…

Sean Kim commented on issue blender/blender#128004 2024-09-24 07:24:03 +02:00
Sculpt: Tip Roundness ignored in Clay Strips Brush when Hardness set to 1 OR Falloff set to Constant

@PratikPB2123 No, I'm not aware of what specifically introduced the regression, bisecting would be appreciated!

Sean Kim commented on issue blender/blender#128004 2024-09-24 07:19:54 +02:00
Sculpt: Tip Roundness ignored in Clay Strips Brush when Hardness set to 1 OR Falloff set to Constant

Thanks for checking @PratikPB2123 - setting this as high prio for now. As far as I'm aware this isn't an intentional change as part of the refactor.

Sean Kim pushed to plane-brushes at Sean-Kim/blender 2024-09-24 04:40:53 +02:00
1e2b73b06a Cleanup: Sculpt: Consolidate Flatten, Fill, and Scrape brushes
Sean Kim commented on pull request blender/blender#128048 2024-09-24 04:05:52 +02:00
Cleanup: Sculpt: Consolidate Flatten, Fill, and Scrape brushes

@blender-bot build

Sean Kim created pull request blender/blender#128048 2024-09-24 04:05:37 +02:00
Cleanup: Sculpt: Consolidate Flatten, Fill, and Scrape brushes
Sean Kim pushed to plane-brushes at Sean-Kim/blender 2024-09-24 03:22:11 +02:00
698905d557 Cleanup: Sculpt: Consolidate Flatten, Fill, and Scrape brushes
Sean Kim pushed to plane-brushes at Sean-Kim/blender 2024-09-24 02:27:17 +02:00
2274ad7010 Cleanup: Sculpt: Consolidate Flatten, Fill, and Scrape brushes
Sean Kim pushed to plane-brushes at Sean-Kim/blender 2024-09-24 02:21:54 +02:00
a9f2f123ef Cleanup: Sculpt: Consolidate Flatten, Fill, and Scrape brushes
cbe2bb6755 Fix #127856: GPv3 sculpt mode delta projection (lock axis) without DrawingPlacement
3f6e36bdda Fix #127994: Stack use after scope constructing sculpt BVH
8da413877b Fix: VSE: hang after making meta strip
c31893ed87 Fix: inconsistent socket identifiers in reroute nodes
Compare 10 commits »
Sean Kim created branch plane-brushes in Sean-Kim/blender 2024-09-24 02:21:54 +02:00
Sean Kim commented on pull request blender/blender#127959 2024-09-23 20:58:43 +02:00
Fix: Avoid accessing face set with invalid index

Looks like a good step. To take it further in the future, what about storing these with std::optional<int>?

Yeah, I was considering that but didnt know what a good pattern to use with this…

Sean Kim pushed to fix-active-face-set at Sean-Kim/blender 2024-09-23 20:14:02 +02:00
23a76512f5 Check for invalid index before accessing active face set
87c4dc418d Revert "Refactor: Sculpt: Remove mesh and multires index from SculptSession"
Compare 2 commits »