Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#127725 2024-09-16 22:06:26 +02:00
Sculpt: Extract deformation position data and logic to a class

I don't mind getting his opinion on this, though I'm curious why you're against it in this case. I understand it can add boilerplate if stuff ends up needing access anyways, but to me this data…

Sean Kim commented on pull request blender/blender#126581 2024-09-16 21:58:36 +02:00
GPv3: Add Bake Grease Pencil Animation operator

I assume you meant frame - frame_start to avoid doing modulo on a negative? But yes, I agree this is better.

Sean Kim commented on pull request blender/blender#127725 2024-09-16 21:35:02 +02:00
Sculpt: Extract deformation position data and logic to a class

I think it makes it more obvious to people reading it for the first time what the relevant / likely usages of the struct are, even if it's not important that we hide these particular internals,…

Sean Kim suggested changes for blender/blender#127725 2024-09-16 21:26:35 +02:00
Sculpt: Extract deformation position data and logic to a class

Overall looks good, just a few minor things

Sean Kim commented on pull request blender/blender#127725 2024-09-16 21:26:34 +02:00
Sculpt: Extract deformation position data and logic to a class

I didn't validate this everywhere, just a casual look over the other files - I think we can make everything but eval private, right?

Sean Kim commented on pull request blender/blender#127725 2024-09-16 21:26:33 +02:00
Sculpt: Extract deformation position data and logic to a class

Missing whatever the end of this comment was intended to be

Sean Kim commented on pull request blender/blender#127666 2024-09-16 21:13:15 +02:00
Refactor: Sculpt: Specialize IK chain FK face set calculation

@blender-bot build

Sean Kim pushed to specialize-pose-chain-fk-init at Sean-Kim/blender 2024-09-16 21:08:13 +02:00
6a59f6d48d Merge branch 'main' of projects.blender.org:blender/blender into specialize-pose-chain-fk-init
0c02840a46 Fix: Incorrect debug assert in average_data_grids
8c98fcc1f1 Fix: Grease pencil vertex paint brush tool not showing
d28956ab99 Tools: Add BPY tool definition option for brush type
12fe0dd0cf Anim: make action/slot assignment code more generic
Compare 49 commits »
Sean Kim deleted branch fix-average-multires-assert from Sean-Kim/blender 2024-09-16 20:52:07 +02:00
Sean Kim pushed to main at blender/blender 2024-09-16 20:52:05 +02:00
0c02840a46 Fix: Incorrect debug assert in average_data_grids
Sean Kim merged pull request blender/blender#127724 2024-09-16 20:52:05 +02:00
Fix: Incorrect debug assert in `average_data_grids`
Sean Kim created pull request blender/blender#127724 2024-09-16 20:40:56 +02:00
Fix: Incorrect debug assert in average_data_grids
Sean Kim pushed to fix-average-multires-assert at Sean-Kim/blender 2024-09-16 20:40:12 +02:00
7d39f45349 Fix: Incorrect debug assert in average_data_grids
Sean Kim created branch fix-average-multires-assert in Sean-Kim/blender 2024-09-16 20:37:10 +02:00
Sean Kim pushed to fix-average-multires-assert at Sean-Kim/blender 2024-09-16 20:37:10 +02:00
246b5b7afd Fix: Incorrect debug assert for multires data average
22cf74d23b Cleanup: Use C++ Array for dependent shape key data
5c792e429f Fix #127638: Crash switching to wireframe with custom bone shape
0d9ab189d1 Fix: #126524: Overlay: Missing loose geometry wireframe with sub-D mesh
d300098ee5 Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024
Compare 10 commits »
Sean Kim opened issue blender/blender#127723 2024-09-16 20:11:04 +02:00
Sculpt: Assert while using Face Set gesture tool on Multires mesh
Sean Kim pushed to specialize-pose-chain-fk-init at Sean-Kim/blender 2024-09-16 18:34:40 +02:00
74398796ab make format
Sean Kim pushed to main at Sean-Kim/.profile 2024-09-15 23:49:03 +02:00
6f711693a8 Update reports/2024.md
Sean Kim pushed to main at Sean-Kim/.profile 2024-09-15 23:48:44 +02:00
110c5a2ea7 Update reports/2024.md
Sean Kim commented on pull request blender/blender#127666 2024-09-15 23:34:46 +02:00
Refactor: Sculpt: Specialize IK chain FK face set calculation

@blender-bot build